Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Side by Side Diff: chrome/common/extensions/extension_permission_set_unittest.cc

Issue 9402018: Experimental Extension Keybinding (first cut). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/extension_permission_set.h" 5 #include "chrome/common/extensions/extension_permission_set.h"
6 6
7 #include "base/json/json_value_serializer.h" 7 #include "base/json/json_value_serializer.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/path_service.h" 9 #include "base/path_service.h"
10 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
(...skipping 773 matching lines...) Expand 10 before | Expand all | Expand 10 after
784 // permission checks. 784 // permission checks.
785 skip.insert(ExtensionAPIPermission::kInput); 785 skip.insert(ExtensionAPIPermission::kInput);
786 skip.insert(ExtensionAPIPermission::kProxy); 786 skip.insert(ExtensionAPIPermission::kProxy);
787 skip.insert(ExtensionAPIPermission::kWebRequest); 787 skip.insert(ExtensionAPIPermission::kWebRequest);
788 skip.insert(ExtensionAPIPermission::kWebRequestBlocking); 788 skip.insert(ExtensionAPIPermission::kWebRequestBlocking);
789 789
790 // This permission requires explicit user action (context menu handler) 790 // This permission requires explicit user action (context menu handler)
791 // so we won't prompt for it for now. 791 // so we won't prompt for it for now.
792 skip.insert(ExtensionAPIPermission::kFileBrowserHandler); 792 skip.insert(ExtensionAPIPermission::kFileBrowserHandler);
793 793
794 // This permission requires explicit user action (shortcut) so we don't
795 // prompt for it.
796 skip.insert(ExtensionAPIPermission::kKeybinding);
797
794 // If you've turned on the experimental command-line flag, we don't need 798 // If you've turned on the experimental command-line flag, we don't need
795 // to warn you further. 799 // to warn you further.
796 skip.insert(ExtensionAPIPermission::kExperimental); 800 skip.insert(ExtensionAPIPermission::kExperimental);
797 801
798 // These are private. 802 // These are private.
799 skip.insert(ExtensionAPIPermission::kChromeAuthPrivate); 803 skip.insert(ExtensionAPIPermission::kChromeAuthPrivate);
800 skip.insert(ExtensionAPIPermission::kChromeosInfoPrivate); 804 skip.insert(ExtensionAPIPermission::kChromeosInfoPrivate);
801 skip.insert(ExtensionAPIPermission::kChromePrivate); 805 skip.insert(ExtensionAPIPermission::kChromePrivate);
802 skip.insert(ExtensionAPIPermission::kFileBrowserPrivate); 806 skip.insert(ExtensionAPIPermission::kFileBrowserPrivate);
803 skip.insert(ExtensionAPIPermission::kInputMethodPrivate); 807 skip.insert(ExtensionAPIPermission::kInputMethodPrivate);
(...skipping 487 matching lines...) Expand 10 before | Expand all | Expand 10 after
1291 AddPattern(&non_empty_extent, "http://www.google.com/*"); 1295 AddPattern(&non_empty_extent, "http://www.google.com/*");
1292 1296
1293 perm_set = new ExtensionPermissionSet( 1297 perm_set = new ExtensionPermissionSet(
1294 empty_apis, non_empty_extent, empty_extent); 1298 empty_apis, non_empty_extent, empty_extent);
1295 EXPECT_FALSE(perm_set->IsEmpty()); 1299 EXPECT_FALSE(perm_set->IsEmpty());
1296 1300
1297 perm_set = new ExtensionPermissionSet( 1301 perm_set = new ExtensionPermissionSet(
1298 empty_apis, empty_extent, non_empty_extent); 1302 empty_apis, empty_extent, non_empty_extent);
1299 EXPECT_FALSE(perm_set->IsEmpty()); 1303 EXPECT_FALSE(perm_set->IsEmpty());
1300 } 1304 }
OLDNEW
« no previous file with comments | « chrome/common/extensions/extension_permission_set.cc ('k') | chrome/common/extensions/extension_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698