scripts/slave/recipes/bisect.py - Issue 940123005: Adding ability to bisect recipe to bisect into dependency repos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/bisect.py

Issue 940123005: Adding ability to bisect recipe to bisect into dependency repos. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@hax

Patch Set: Addressing feedback, adding TODOs Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/auto_bisect/test_results_cache.py ('k') | scripts/slave/recipes/bisect.expected/basic.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/bisect.py

diff --git a/scripts/slave/recipes/bisect.py b/scripts/slave/recipes/bisect.py

index e9475d0496b46c9b256a610d422c7248d75d49c1..03821df46712a6352ef3a61b14756e0e6040d1f0 100644

--- a/scripts/slave/recipes/bisect.py

+++ b/scripts/slave/recipes/bisect.py

@@ -32,7 +32,8 @@ def GenSteps(api):

_ensure_checkout(api)

if (not bisector.failed and bisector.check_improvement_direction() and

bisector.check_regression_confidence()):

- _bisect_main_loop(bisector)

+ if not bisector.check_bisect_finished(bisector.good_rev):

+ _bisect_main_loop(bisector)

else: #pragma: no cover

bisector.bisect_over = True

bisector.print_result()

« no previous file with comments | « scripts/slave/recipe_modules/auto_bisect/test_results_cache.py ('k') | scripts/slave/recipes/bisect.expected/basic.json » ('j') | no next file with comments »