Chromium Code Reviews| Index: scripts/slave/recipe_modules/auto_bisect/api.py |
| diff --git a/scripts/slave/recipe_modules/auto_bisect/api.py b/scripts/slave/recipe_modules/auto_bisect/api.py |
| index e4384d8ba0f8285ccd759a26ee50fe054763a375..08fe0e1e761cf3b9d5fc2ed3a97b11c8024648fc 100644 |
| --- a/scripts/slave/recipe_modules/auto_bisect/api.py |
| +++ b/scripts/slave/recipe_modules/auto_bisect/api.py |
| @@ -16,20 +16,27 @@ from . import perf_revision_state |
| class AutoBisectApi(recipe_api.RecipeApi): |
| """A module for bisect specific functions.""" |
| + # Number of seconds to wait between polls for test results |
| POLLING_INTERVAL = 60 |
| + # GS bucket to use for communicating results and job state between bisector |
| + # and tester bots |
| BUCKET = 'chrome-perf' |
| + # Directory within the above bucket to store results |
| RESULTS_GS_DIR = 'bisect-results' |
| GS_RESULTS_URL = 'gs://%s/%s/' % (BUCKET, RESULTS_GS_DIR) |
| + # Repo for triggering build jobs |
| SVN_REPO_URL = 'svn://svn.chromium.org/chrome-try/try-perf' |
| + # Email to send on try jobs (for build requests) since git try will not |
| + # necessarily rely on a local checkout for that information |
|
qyearsley
2015/03/13 23:38:59
[Optional] Could add periods after the comments ab
|
| + BOT_EMAIL = 'chrome_bot@chromium.org' |
| def __init__(self, *args, **kwargs): |
| super(AutoBisectApi, self).__init__(*args, **kwargs) |
| self.override_poll_interval = None |
| - def create_bisector(self, bisect_config): |
| + def create_bisector(self, bisect_config_dict): |
| """Passes the api and the config dictionary to the Bisector constructor.""" |
| - bisect_config_dict = bisect_config |
| - self.override_poll_interval = bisect_config_dict.get('poll_sleep', None) |
| + self.override_poll_interval = bisect_config_dict.get('poll_sleep') |
| revision_class = self._get_revision_class(bisect_config_dict['test_type']) |
| return bisector.Bisector(self, bisect_config_dict, revision_class) |