Parsing of basic module declarations (no imports/exports yet).

Parsing of basic module declarations (no imports/exports yet).

Module definitions are not compiled or otherwise executed yet.
Toplevel module identifiers are bound but never initialized.

R=kmillikin@chromium.org,mstarzinger@google.com
BUG=
TEST=

Committed: https://code.google.com/p/v8/source/detail?r=10759

[Lasse Reichstein Nielsen, 2012-02-20 09:55:48]

LGTM

http://codereview.chromium.org/9401008/diff/1/src/parser.cc
File src/parser.cc (right):

http://codereview.chromium.org/9401008/diff/1/src/parser.cc#newcode1285
src/parser.cc:1285: Consume(Token::PERIOD);
Can be shortened to
 while (Check(Token::PERIOD)) {
which does the test and consume.

http://codereview.chromium.org/9401008/diff/1/src/parser.cc#newcode1310
src/parser.cc:1310: Handle<String> symbol = GetSymbol(ok);
Should this continue after an error?
I.e., shouldn't it rather be  
 ... GetSymbol(CHECK_OK);
?
Or perhaps check the token type before doing the GetSymbol on it, so you don't
try to GetSymbol on a non-identifier/non-string value.
The current code doing all the extra checking on *ok seems less readable than
possible,

[rossberg, 2012-02-20 12:30:04]

http://codereview.chromium.org/9401008/diff/1/src/parser.cc
File src/parser.cc (right):

http://codereview.chromium.org/9401008/diff/1/src/parser.cc#newcode1285
src/parser.cc:1285: Consume(Token::PERIOD);
On 2012/02/20 09:55:48, Lasse Reichstein Nielsen wrote:
> Can be shortened to
>  while (Check(Token::PERIOD)) {
> which does the test and consume.

Done.

http://codereview.chromium.org/9401008/diff/1/src/parser.cc#newcode1310
src/parser.cc:1310: Handle<String> symbol = GetSymbol(ok);
On 2012/02/20 09:55:48, Lasse Reichstein Nielsen wrote:
> Should this continue after an error?
> I.e., shouldn't it rather be  
>  ... GetSymbol(CHECK_OK);
> ?
> Or perhaps check the token type before doing the GetSymbol on it, so you don't
> try to GetSymbol on a non-identifier/non-string value.
> The current code doing all the extra checking on *ok seems less readable than
> possible,

Right, I don't know what I was thinking. Much simplified now.

[Lasse Reichstein Nielsen, 2012-02-21 13:46:02]

Still LGTM!

http://codereview.chromium.org/9401008/diff/4001/src/parser.cc
File src/parser.cc (right):

http://codereview.chromium.org/9401008/diff/4001/src/parser.cc#newcode1316
src/parser.cc:1316: symbol = GetSymbol(CHECK_OK);
Great! :)