runtime/vm/scavenger.cc - Issue 9398014: Ignore deleted handles when processing weak roots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/scavenger.cc

Issue 9398014: Ignore deleted handles when processing weak roots. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: final revision Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/scavenger.cc

diff --git a/runtime/vm/scavenger.cc b/runtime/vm/scavenger.cc

index d322981bafa12f48dc266446600044ae33e793f8..dff022f5ca977eeeca0cbc871a3f847386b35dbd 100644

--- a/runtime/vm/scavenger.cc

+++ b/runtime/vm/scavenger.cc

@@ -140,6 +140,7 @@ class ScavengerWeakVisitor : public HandleVisitor {

WeakPersistentHandle* handle =

reinterpret_cast<WeakPersistentHandle*>(addr);

RawObject* raw_obj = handle->raw();

+ if (!raw_obj->IsHeapObject()) return;

uword raw_addr = RawObject::ToAddr(raw_obj);

if (scavenger_->from_->Contains(raw_addr)) {

uword header = *reinterpret_cast<uword*>(raw_addr);

« no previous file with comments | « runtime/vm/gc_marker.cc ('k') | no next file » | no next file with comments »