Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1522)

Unified Diff: runtime/vm/scavenger.cc

Issue 9398014: Ignore deleted handles when processing weak roots. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/gc_marker.cc ('K') | « runtime/vm/gc_marker.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/scavenger.cc
diff --git a/runtime/vm/scavenger.cc b/runtime/vm/scavenger.cc
index d322981bafa12f48dc266446600044ae33e793f8..e87139ec92dcf059bc2db06f3ab6c90acb92f332 100644
--- a/runtime/vm/scavenger.cc
+++ b/runtime/vm/scavenger.cc
@@ -140,6 +140,10 @@ class ScavengerWeakVisitor : public HandleVisitor {
WeakPersistentHandle* handle =
reinterpret_cast<WeakPersistentHandle*>(addr);
RawObject* raw_obj = handle->raw();
+ if (!raw_obj->IsHeapObject()) {
+ // Deleted handles are identified by a Smi as the raw object value.
+ return;
+ }
uword raw_addr = RawObject::ToAddr(raw_obj);
if (scavenger_->from_->Contains(raw_addr)) {
uword header = *reinterpret_cast<uword*>(raw_addr);
« runtime/vm/gc_marker.cc ('K') | « runtime/vm/gc_marker.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698