runtime/vm/dart_api_impl_test.cc - Issue 9398014: Ignore deleted handles when processing weak roots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl_test.cc

Issue 9398014: Ignore deleted handles when processing weak roots. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/dart_api_impl_test.cc

diff --git a/runtime/vm/dart_api_impl_test.cc b/runtime/vm/dart_api_impl_test.cc

index e041a615c056eb16ad1dfe7e550fdf88a4cf095c..f8fd23d2dd0d666691f4e4c310e8f6b7d1d7d369 100644

--- a/runtime/vm/dart_api_impl_test.cc

+++ b/runtime/vm/dart_api_impl_test.cc

@@ -1123,6 +1123,10 @@ TEST_CASE(WeakPersistentHandle) {

Dart_DeletePersistentHandle(weak_new_ref);

Dart_DeletePersistentHandle(weak_old_ref);

+ // garbage collect one last time to revisit deleted handles

+ Isolate::Current()->heap()->CollectGarbage(Heap::kNew);

+ Isolate::Current()->heap()->CollectGarbage(Heap::kOld);

}

« no previous file with comments | « no previous file | runtime/vm/gc_marker.cc » ('j') | runtime/vm/gc_marker.cc » ('J')