Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pylib/gyp/generator/ninja.py

Issue 9395082: Quote arguments properly in rules for cmd on Windows ninja. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pylib/gyp/msvs_emulation.py » ('j') | pylib/gyp/msvs_emulation.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/generator/ninja.py
===================================================================
--- pylib/gyp/generator/ninja.py (revision 1217)
+++ pylib/gyp/generator/ninja.py (working copy)
@@ -945,10 +945,8 @@
args = [self.ExpandSpecial(arg, self.base_to_build) for arg in args]
env = self.ComputeExportEnvString(env)
if self.flavor == 'win':
- # TODO(scottmg): Really don't want encourage cygwin, but I'm not sure
- # how much sh is depended upon. For now, double quote args to make most
- # things work.
- command = args[0] + ' "' + '" "'.join(args[1:]) + '""'
+ # TODO(scottmg): Respect msvs_cygwin setting here.
+ command = gyp.msvs_emulation.EncodeCmdExeArgList(args)
else:
command = gyp.common.EncodePOSIXShellList(args)
if env:
« no previous file with comments | « no previous file | pylib/gyp/msvs_emulation.py » ('j') | pylib/gyp/msvs_emulation.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698