Issue 9395082: Quote arguments properly in rules for cmd on Windows ninja.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9395082: Quote arguments properly in rules for cmd on Windows ninja. (Closed)

Created:
8 years, 10 months ago by scottmg

Modified:
8 years, 10 months ago

Reviewers:
Nico

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Quote arguments properly in rules for cmd on Windows ninja. Committed: https://code.google.com/p/gyp/source/detail?r=1218

Patch Set 3 : #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	pylib/gyp/generator/ninja.py	View	1	1 chunk	+2 lines, -4 lines	0 comments	Download
	M	pylib/gyp/msvs_emulation.py	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

lgtm https://chromiumcodereview.appspot.com/9395082/diff/1/pylib/gyp/msvs_emulation.py File pylib/gyp/msvs_emulation.py (right): https://chromiumcodereview.appspot.com/9395082/diff/1/pylib/gyp/msvs_emulation.py#newcode44 pylib/gyp/msvs_emulation.py:44: def EncodeCmdExeArgList(args): The posix versions of these are ...

8 years, 10 months ago (2012-02-21 05:56:14 UTC) #2

scottmg

8 years, 10 months ago (2012-02-21 06:08:19 UTC) #3

https://chromiumcodereview.appspot.com/9395082/diff/1/pylib/gyp/msvs_emulatio...
File pylib/gyp/msvs_emulation.py (right):

https://chromiumcodereview.appspot.com/9395082/diff/1/pylib/gyp/msvs_emulatio...
pylib/gyp/msvs_emulation.py:44: def EncodeCmdExeArgList(args):
On 2012/02/21 05:56:14, Nico wrote:
> The posix versions of these are called EncodePOSIXShellArgument and
> EncodePOSIXShellList, so maybe call this EncodeCmdExeList for consistency?

Done.

Expand Messages | Collapse Messages

Issue 9395082: Quote arguments properly in rules for cmd on Windows ninja. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages