Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: chrome/browser/sync/glue/preference_data_type_controller_unittest.cc

Issue 9395058: [Sync] Remove SyncableServiceAdapter. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/preference_data_type_controller_unittest.cc
diff --git a/chrome/browser/sync/glue/preference_data_type_controller_unittest.cc b/chrome/browser/sync/glue/preference_data_type_controller_unittest.cc
deleted file mode 100644
index af880d69d40b9b197de6a9f5d30082e2c0d9d77f..0000000000000000000000000000000000000000
--- a/chrome/browser/sync/glue/preference_data_type_controller_unittest.cc
+++ /dev/null
@@ -1,186 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "testing/gtest/include/gtest/gtest.h"
-
-#include "base/bind.h"
-#include "base/bind_helpers.h"
-#include "base/callback.h"
-#include "base/memory/scoped_ptr.h"
-#include "base/message_loop.h"
-#include "base/tracked_objects.h"
-#include "chrome/browser/sync/glue/change_processor_mock.h"
-#include "chrome/browser/sync/glue/data_type_controller_mock.h"
-#include "chrome/browser/sync/glue/model_associator_mock.h"
-#include "chrome/browser/sync/glue/preference_data_type_controller.h"
-#include "chrome/browser/sync/profile_sync_components_factory_mock.h"
-#include "chrome/browser/sync/profile_sync_service_mock.h"
-#include "chrome/test/base/profile_mock.h"
-#include "content/test/test_browser_thread.h"
-
-using browser_sync::ChangeProcessorMock;
-using browser_sync::DataTypeController;
-using browser_sync::ModelAssociatorMock;
-using browser_sync::PreferenceDataTypeController;
-using browser_sync::StartCallbackMock;
-using content::BrowserThread;
-using testing::_;
-using testing::DoAll;
-using testing::InvokeWithoutArgs;
-using testing::Return;
-using testing::SetArgumentPointee;
-
-class SyncPreferenceDataTypeControllerTest : public testing::Test {
- public:
- SyncPreferenceDataTypeControllerTest()
- : ui_thread_(BrowserThread::UI, &message_loop_) {}
-
- virtual void SetUp() {
- profile_sync_factory_.reset(new ProfileSyncComponentsFactoryMock());
- preference_dtc_ =
- new PreferenceDataTypeController(profile_sync_factory_.get(),
- &profile_,
- &service_);
- }
-
- protected:
- void SetStartExpectations() {
- model_associator_ = new ModelAssociatorMock();
- change_processor_ = new ChangeProcessorMock();
- EXPECT_CALL(*profile_sync_factory_, CreatePreferenceSyncComponents(_, _)).
- WillOnce(Return(
- ProfileSyncComponentsFactory::SyncComponents(model_associator_,
- change_processor_)));
- }
-
- void SetAssociateExpectations() {
- EXPECT_CALL(*model_associator_, CryptoReadyIfNecessary()).
- WillRepeatedly(Return(true));
- EXPECT_CALL(*model_associator_, SyncModelHasUserCreatedNodes(_)).
- WillRepeatedly(DoAll(SetArgumentPointee<0>(true), Return(true)));
- EXPECT_CALL(*model_associator_, AssociateModels(_)).
- WillRepeatedly(Return(true));
- }
-
- void SetActivateExpectations() {
- EXPECT_CALL(service_, ActivateDataType(_, _, _));
- }
-
- void SetStopExpectations() {
- EXPECT_CALL(service_, DeactivateDataType(_));
- EXPECT_CALL(*model_associator_, DisassociateModels(_));
- }
-
- void PumpLoop() {
- message_loop_.RunAllPending();
- }
-
- MessageLoopForUI message_loop_;
- content::TestBrowserThread ui_thread_;
- scoped_refptr<PreferenceDataTypeController> preference_dtc_;
- scoped_ptr<ProfileSyncComponentsFactoryMock> profile_sync_factory_;
- ProfileMock profile_;
- ProfileSyncServiceMock service_;
- ModelAssociatorMock* model_associator_;
- ChangeProcessorMock* change_processor_;
- StartCallbackMock start_callback_;
-};
-
-TEST_F(SyncPreferenceDataTypeControllerTest, Start) {
- SetStartExpectations();
- SetAssociateExpectations();
- SetActivateExpectations();
- EXPECT_EQ(DataTypeController::NOT_RUNNING, preference_dtc_->state());
- EXPECT_CALL(start_callback_, Run(DataTypeController::OK, _));
- preference_dtc_->Start(
- base::Bind(&StartCallbackMock::Run, base::Unretained(&start_callback_)));
- EXPECT_EQ(DataTypeController::RUNNING, preference_dtc_->state());
-}
-
-TEST_F(SyncPreferenceDataTypeControllerTest, StartFirstRun) {
- SetStartExpectations();
- SetAssociateExpectations();
- SetActivateExpectations();
- EXPECT_CALL(*model_associator_, SyncModelHasUserCreatedNodes(_)).
- WillRepeatedly(DoAll(SetArgumentPointee<0>(false), Return(true)));
- EXPECT_CALL(start_callback_, Run(DataTypeController::OK_FIRST_RUN, _));
- preference_dtc_->Start(
- base::Bind(&StartCallbackMock::Run, base::Unretained(&start_callback_)));
-}
-
-TEST_F(SyncPreferenceDataTypeControllerTest, StartOk) {
- SetStartExpectations();
- SetAssociateExpectations();
- SetActivateExpectations();
- EXPECT_CALL(*model_associator_, SyncModelHasUserCreatedNodes(_)).
- WillRepeatedly(DoAll(SetArgumentPointee<0>(true), Return(true)));
-
- EXPECT_CALL(start_callback_, Run(DataTypeController::OK, _));
- preference_dtc_->Start(
- base::Bind(&StartCallbackMock::Run, base::Unretained(&start_callback_)));
-}
-
-TEST_F(SyncPreferenceDataTypeControllerTest, StartAssociationFailed) {
- SetStartExpectations();
- SetAssociateExpectations();
- EXPECT_CALL(*model_associator_, AssociateModels(_)).
- WillRepeatedly(DoAll(browser_sync::SetSyncError(syncable::PREFERENCES),
- Return(false)));
-
- EXPECT_CALL(start_callback_,
- Run(DataTypeController::ASSOCIATION_FAILED, _));
- preference_dtc_->Start(
- base::Bind(&StartCallbackMock::Run, base::Unretained(&start_callback_)));
- EXPECT_EQ(DataTypeController::DISABLED, preference_dtc_->state());
-}
-
-TEST_F(SyncPreferenceDataTypeControllerTest,
- StartAssociationTriggersUnrecoverableError) {
- SetStartExpectations();
- // Set up association to fail with an unrecoverable error.
- EXPECT_CALL(*model_associator_, CryptoReadyIfNecessary()).
- WillRepeatedly(Return(true));
- EXPECT_CALL(*model_associator_, SyncModelHasUserCreatedNodes(_)).
- WillRepeatedly(DoAll(SetArgumentPointee<0>(false), Return(false)));
- EXPECT_CALL(start_callback_,
- Run(DataTypeController::UNRECOVERABLE_ERROR, _));
- preference_dtc_->Start(
- base::Bind(&StartCallbackMock::Run, base::Unretained(&start_callback_)));
- EXPECT_EQ(DataTypeController::NOT_RUNNING, preference_dtc_->state());
-}
-
-TEST_F(SyncPreferenceDataTypeControllerTest, Stop) {
- SetStartExpectations();
- SetAssociateExpectations();
- SetActivateExpectations();
- SetStopExpectations();
-
- EXPECT_EQ(DataTypeController::NOT_RUNNING, preference_dtc_->state());
-
- EXPECT_CALL(start_callback_, Run(DataTypeController::OK, _));
- preference_dtc_->Start(
- base::Bind(&StartCallbackMock::Run, base::Unretained(&start_callback_)));
- EXPECT_EQ(DataTypeController::RUNNING, preference_dtc_->state());
- preference_dtc_->Stop();
- EXPECT_EQ(DataTypeController::NOT_RUNNING, preference_dtc_->state());
-}
-
-TEST_F(SyncPreferenceDataTypeControllerTest, OnUnrecoverableError) {
- SetStartExpectations();
- SetAssociateExpectations();
- SetActivateExpectations();
- EXPECT_CALL(*model_associator_, SyncModelHasUserCreatedNodes(_)).
- WillRepeatedly(DoAll(SetArgumentPointee<0>(true), Return(true)));
- EXPECT_CALL(service_, OnUnrecoverableError(_,_)).
- WillOnce(InvokeWithoutArgs(preference_dtc_.get(),
- &PreferenceDataTypeController::Stop));
- SetStopExpectations();
-
- EXPECT_CALL(start_callback_, Run(DataTypeController::OK, _));
- preference_dtc_->Start(
- base::Bind(&StartCallbackMock::Run, base::Unretained(&start_callback_)));
- // This should cause preference_dtc_->Stop() to be called.
- preference_dtc_->OnUnrecoverableError(FROM_HERE, "Test");
- PumpLoop();
-}

Powered by Google App Engine
This is Rietveld 408576698