Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: content/renderer/media/audio_renderer_impl.cc

Issue 9395057: Fix muted audio when playback rate != 1.0 or 0.0 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/audio/audio_util.h » ('j') | media/base/seekable_buffer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/audio_renderer_impl.cc
diff --git a/content/renderer/media/audio_renderer_impl.cc b/content/renderer/media/audio_renderer_impl.cc
index e2568da79c05e7dd85f7f114c96f7960ea5d41dd..781fa191aad055861fd61c7422e1365b4e393188 100644
--- a/content/renderer/media/audio_renderer_impl.cc
+++ b/content/renderer/media/audio_renderer_impl.cc
@@ -218,11 +218,10 @@ size_t AudioRendererImpl::Render(const std::vector<float*>& audio_data,
const size_t buf_size = number_of_frames * bytes_per_frame;
scoped_array<uint8> buf(new uint8[buf_size]);
- uint32 filled = FillBuffer(buf.get(), buf_size, request_delay);
- DCHECK_LE(filled, buf_size);
- UpdateEarliestEndTime(filled, request_delay, base::Time::Now());
-
- uint32 filled_frames = filled / bytes_per_frame;
+ uint32 filled_frames = FillBuffer(buf.get(), number_of_frames, request_delay);
acolwell GONE FROM CHROMIUM 2012/02/22 07:51:40 nit: rename frames_filled to be consistent with by
vrk (LEFT CHROMIUM) 2012/02/23 20:33:06 Done.
+ uint32 bytes_filled = filled_frames * bytes_per_frame;
+ DCHECK_LE(bytes_filled, buf_size);
+ UpdateEarliestEndTime(bytes_filled, request_delay, base::Time::Now());
// Deinterleave each audio channel.
int channels = audio_data.size();
« no previous file with comments | « no previous file | media/audio/audio_util.h » ('j') | media/base/seekable_buffer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698