Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: dart/frog/leg/resolver.dart

Issue 9395043: Only warn that const expressions are not implemented. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dart/tests/co19/co19-leg.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/leg/resolver.dart
diff --git a/dart/frog/leg/resolver.dart b/dart/frog/leg/resolver.dart
index 1b68d4fcd3d7ce2ca572fa2f95a86497b569b1ef..f5ae8c7c2e92d020b866425b9f2ac21fa19f5610 100644
--- a/dart/frog/leg/resolver.dart
+++ b/dart/frog/leg/resolver.dart
@@ -852,7 +852,10 @@ class ResolverVisitor extends CommonResolverVisitor<Element> {
}
visitNewExpression(NewExpression node) {
- if (node.isConst()) cancel(node, 'const expressions are not implemented');
+ if (node.isConst()) {
+ warning(node, MessageKind.GENERIC,
+ ['const expressions are not implemented']);
+ }
Node selector = node.send.selector;
if (selector.asTypeAnnotation() === null) {
cancel(
@@ -915,7 +918,10 @@ class ResolverVisitor extends CommonResolverVisitor<Element> {
}
visitLiteralList(LiteralList node) {
- if (node.isConst()) cancel(node, 'const literal lists are not implemented');
+ if (node.isConst()) {
+ warning(node, MessageKind.GENERIC,
+ ['const literal lists are not implemented']);
+ }
visit(node.elements);
}
« no previous file with comments | « no previous file | dart/tests/co19/co19-leg.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698