Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Unified Diff: runtime/vm/ic_data_test.cc

Issue 9395016: First part of new ICData infrastructure: use a wrapper object instead of an array. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/ic_data_test.cc
===================================================================
--- runtime/vm/ic_data_test.cc (revision 4401)
+++ runtime/vm/ic_data_test.cc (working copy)
@@ -1,75 +0,0 @@
-// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
-#include "vm/ic_data.h"
-#include "vm/code_index_table.h"
-#include "vm/unit_test.h"
-
-namespace dart {
-
-static RawFunction* GetDummyTarget(const char* name) {
- const String& function_name = String::Handle(String::NewSymbol(name));
- const bool is_static = false;
- const bool is_const = false;
- return Function::New(function_name,
- RawFunction::kFunction,
- is_static,
- is_const,
- 0);
-}
-
-
-static bool SameClassArrays(const GrowableArray<const Class*>& a,
- const GrowableArray<const Class*>& b) {
- if (a.length() != b.length()) {
- return false;
- }
- for (int i = 0; i < a.length(); i++) {
- if (a[i]->raw() != b[i]->raw()) {
- return false;
- }
- }
- return true;
-}
-
-
-TEST_CASE(ICDataTest) {
- const String& name = String::Handle(String::New("Luxemburgerli"));
- ICData ic_data(name, 1);
- EXPECT_EQ(1, ic_data.NumberOfArgumentsChecked());
- EXPECT_EQ(0, ic_data.NumberOfChecks());
- EXPECT_EQ(name.raw(), ic_data.FunctionName());
- GrowableArray<const Class*> classes;
- const Function& target = Function::Handle(GetDummyTarget(name.ToCString()));
- ObjectStore* object_store = Isolate::Current()->object_store();
- const Class& smi_class = Class::ZoneHandle(object_store->smi_class());
- classes.Add(&smi_class);
- ic_data.AddCheck(classes, target);
-
- EXPECT_EQ(1, ic_data.NumberOfArgumentsChecked());
- EXPECT_EQ(1, ic_data.NumberOfChecks());
- EXPECT_EQ(name.raw(), ic_data.FunctionName());
-
- GrowableArray<const Class*> test_classes;
- Function& test_target = Function::Handle();
- ic_data.GetCheckAt(0, &test_classes, &test_target);
- Class& test_class_1 = Class::Handle();
- Function& test_target_1 = Function::Handle();
- ic_data.GetOneClassCheckAt(0, &test_class_1, &test_target_1);
-
- EXPECT(SameClassArrays(classes, test_classes));
- EXPECT_EQ(test_classes[0]->raw(), test_class_1.raw());
- EXPECT_EQ(target.raw(), test_target.raw());
- EXPECT_EQ(test_target.raw(), test_target_1.raw());
-
- const Function& new_target =
- Function::Handle(GetDummyTarget(name.ToCString()));
- ic_data.SetCheckAt(0, classes, new_target);
- ic_data.GetCheckAt(0, &test_classes, &test_target);
-
- EXPECT(SameClassArrays(classes, test_classes));
- EXPECT_EQ(new_target.raw(), test_target.raw());
-}
-
-} // namespace dart

Powered by Google App Engine
This is Rietveld 408576698