SPDY Proxy - Bug fix to handle flow control (spdy/2.1)

SPDY Proxy - Bug fix to handle flow control (spdy/2.1)
Increase receive window size with bytes read.

BUG=114064
R=willchan
TEST=spdy tests. Accessing mail with SPDY proxy enabled.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122395

[ramant (doing other things), 2012-02-14 05:08:41]

Hi willchan and rch,
  This change seems to fix SPDY proxy not working SPDY/2.1. What do you think
about this change?

thanks,
raman

[willchan no longer on Chromium, 2012-02-14 06:11:47]

http://codereview.chromium.org/9392030/diff/1/net/spdy/spdy_proxy_client_sock...
File net/spdy/spdy_proxy_client_socket.cc (right):

http://codereview.chromium.org/9392030/diff/1/net/spdy/spdy_proxy_client_sock...
net/spdy/spdy_proxy_client_socket.cc:180: memcpy(user_buffer_->data(),
data->data(), bytes_to_copy);
Don't you need to do
bytes_read += bytes_to_copy?

[ramant (doing other things), 2012-02-14 06:34:28]

http://codereview.chromium.org/9392030/diff/1/net/spdy/spdy_proxy_client_sock...
File net/spdy/spdy_proxy_client_socket.cc (right):

http://codereview.chromium.org/9392030/diff/1/net/spdy/spdy_proxy_client_sock...
net/spdy/spdy_proxy_client_socket.cc:180: memcpy(user_buffer_->data(),
data->data(), bytes_to_copy);
On 2012/02/14 06:11:48, willchan wrote:
> Don't you need to do
> bytes_read += bytes_to_copy?

I lost that change when I moved my change from one tree to another tree. Thanks
for catching it. Tested it with the above statement.

Done.

[willchan no longer on Chromium, 2012-02-14 19:16:44]

lgtm

http://codereview.chromium.org/9392030/diff/10003/net/spdy/spdy_http_stream.cc
File net/spdy/spdy_http_stream.cc (right):

http://codereview.chromium.org/9392030/diff/10003/net/spdy/spdy_http_stream.c...
net/spdy/spdy_http_stream.cc:132: if (spdy_session_)
We don't need this if statement at all, do we?

[ramant (doing other things), 2012-02-16 00:23:14]

Hi willchan,
  Integrated with the code from the trunk and removed the if statement. Could
you look at the change and bless it one more time.

thanks much,
raman

http://codereview.chromium.org/9392030/diff/10003/net/spdy/spdy_http_stream.cc
File net/spdy/spdy_http_stream.cc (right):

http://codereview.chromium.org/9392030/diff/10003/net/spdy/spdy_http_stream.c...
net/spdy/spdy_http_stream.cc:132: if (spdy_session_)
On 2012/02/14 19:16:44, willchan wrote:
> We don't need this if statement at all, do we?

Done.

[willchan no longer on Chromium, 2012-02-16 19:01:29]

LGTM

[commit-bot: I haz the power, 2012-02-16 19:05:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/9392030/13001

[commit-bot: I haz the power, 2012-02-16 20:09:49]

Try job failure for 9392030-13001 (retry) on linux_rel for step "check_deps".
It's a second try, previously, step "check_deps" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-02-16 21:52:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/9392030/13001

[commit-bot: I haz the power, 2012-02-16 23:05:07]

Try job failure for 9392030-13001 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...