client/html/src/SVGElementWrappingImplementation.dart - Issue 9392028: Ensure that newly-constructed elements don't have parents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/html/src/SVGElementWrappingImplementation.dart

Issue 9392028: Ensure that newly-constructed elements don't have parents. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« client/html/src/ElementWrappingImplementation.dart ('K') | « client/html/src/ElementWrappingImplementation.dart ('k') | client/tests/client/html/ElementTests.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: client/html/src/SVGElementWrappingImplementation.dart

diff --git a/client/html/src/SVGElementWrappingImplementation.dart b/client/html/src/SVGElementWrappingImplementation.dart

index 2e5861792a5473be3760531d45402162bd1e84f9..dbc200c381f41359e9dc0ac74049c003850a54c2 100644

--- a/client/html/src/SVGElementWrappingImplementation.dart

+++ b/client/html/src/SVGElementWrappingImplementation.dart

@@ -29,7 +29,7 @@ class SVGElementWrappingImplementation extends ElementWrappingImplementation imp

}

parentTag.innerHTML = svg;

- if (parentTag.elements.length == 1) return parentTag.elements[0];

+ if (parentTag.elements.length == 1) return parentTag.nodes.removeLast();

throw new IllegalArgumentException('SVG had ${parentTag.elements.length} ' +

'top-level elements but 1 expected');