Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: ui/views/controls/textfield/textfield_views_model.h

Issue 9390022: Simplify handling of BiDi cursor movement (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix merge breakage Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/textfield/textfield_views_model.h
diff --git a/ui/views/controls/textfield/textfield_views_model.h b/ui/views/controls/textfield/textfield_views_model.h
index c6c1c400d998ab9609d313db8269e984010a8d85..cf6dea7c88ee68854750c2feb362fabbc4ac7949 100644
--- a/ui/views/controls/textfield/textfield_views_model.h
+++ b/ui/views/controls/textfield/textfield_views_model.h
@@ -141,9 +141,6 @@ class VIEWS_EXPORT TextfieldViewsModel {
// Returns the selected text.
string16 GetSelectedText() const;
- // Gets the selected range.
- void GetSelectedRange(ui::Range* range) const;
-
// The current composition text will be confirmed. The selection starts with
// the range's start position, and ends with the range's end position,
// therefore the cursor position becomes the end position.
@@ -259,7 +256,7 @@ class VIEWS_EXPORT TextfieldViewsModel {
void ClearRedoHistory();
// Executes and records edit operations.
- void ExecuteAndRecordDelete(size_t from, size_t to, bool mergeable);
+ void ExecuteAndRecordDelete(ui::Range range, bool mergeable);
void ExecuteAndRecordReplaceSelection(internal::MergeType merge_type,
const string16& text);
void ExecuteAndRecordReplace(internal::MergeType merge_type,
« no previous file with comments | « ui/views/controls/textfield/native_textfield_views_unittest.cc ('k') | ui/views/controls/textfield/textfield_views_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698