Get rid of ShowPageInfo on WebContents and WebContentsDelegate. Chrome shouldn't have to go throu...

chrome/browser/ui/gtk/location_bar_view_gtk.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gtk/location_bar_view_gtk.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 52 matching lines @@
 #include "ui/base/dragdrop/gtk_dnd_util.h"
 #include "ui/base/gtk/gtk_hig_constants.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/canvas_skia_paint.h"
 #include "ui/gfx/font.h"
 #include "ui/gfx/gtk_util.h"
 #include "ui/gfx/image/image.h"
 #include "webkit/glue/window_open_disposition.h"
 
+using content::NavigationController;
 using content::NavigationEntry;
 using content::OpenURLParams;
 using content::WebContents;
 
 namespace {
 
 // We are positioned with a little bit of extra space that we don't use now.
 const int kTopMargin = 1;
 const int kBottomMargin = 1;
 const int kLeftMargin = 1;
@@ skipping 951 matching lines @@
     // Do not show page info if the user has been editing the location
     // bar, or the location bar is at the NTP.
     if (location_entry()->IsEditingOrEmpty())
       return FALSE;
 
     // (0,0) event coordinates indicates that the release came at the end of
     // a drag.
     if (event->x == 0 && event->y == 0)
       return FALSE;
 
-    NavigationEntry* nav_entry = tab->GetController().GetActiveEntry();
+    const NavigationController& controller = tab->GetController();
+    NavigationEntry* nav_entry = controller.GetActiveEntry();
     if (!nav_entry) {
       NOTREACHED();
       return FALSE;
     }
-    tab->ShowPageInfo(nav_entry->GetURL(), nav_entry->GetSSL(), true);
+    Browser* browser = Browser::GetBrowserForController(&controller, NULL);

[Ben Goodger (Google), 2012/02/14 17:52:56]

You shouldn't need to do this. This object has a browser_ field that corresponds
to the browser_ it's attached to.

[jam, 2012/02/14 18:06:08]

thanks, I missed that, i'll send you a cl updating this

+    browser->ShowPageInfo(nav_entry->GetURL(), nav_entry->GetSSL(), true);
     return TRUE;
   } else if (event->button == 2) {
     // When the user middle clicks on the location icon, try to open the
     // contents of the PRIMARY selection in the current tab.
     // If the click was outside our bounds, do nothing.
     if (!gtk_util::WidgetBounds(sender).Contains(
             gfx::Point(event->x, event->y))) {
       return FALSE;
     }
 
@@ skipping 586 matching lines @@
   std::string badge_text = page_action_->GetBadgeText(tab_id);
   if (badge_text.empty())
     return FALSE;
 
   gfx::CanvasSkiaPaint canvas(event, false);
   GtkAllocation allocation;
   gtk_widget_get_allocation(widget, &allocation);
   page_action_->PaintBadge(&canvas, gfx::Rect(allocation), tab_id);
   return FALSE;
 }