Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: chrome/browser/ui/browser.h

Issue 9390015: Get rid of ShowPageInfo on WebContents and WebContentsDelegate. Chrome shouldn't have to go throu... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix gtk+mac Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_H_
6 #define CHROME_BROWSER_UI_BROWSER_H_ 6 #define CHROME_BROWSER_UI_BROWSER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 537 matching lines...) Expand 10 before | Expand all | Expand 10 after
548 #if defined(OS_CHROMEOS) 548 #if defined(OS_CHROMEOS)
549 void Search(); 549 void Search();
550 void ShowKeyboardOverlay(); 550 void ShowKeyboardOverlay();
551 #endif 551 #endif
552 552
553 // Page-related commands 553 // Page-related commands
554 void BookmarkCurrentPage(); 554 void BookmarkCurrentPage();
555 void SavePage(); 555 void SavePage();
556 void ViewSelectedSource(); 556 void ViewSelectedSource();
557 void ShowFindBar(); 557 void ShowFindBar();
558 void ShowPageInfo(const GURL& url,
559 const content::SSLStatus& ssl,
560 bool show_history);
558 561
559 // Returns true if the Browser supports the specified feature. The value of 562 // Returns true if the Browser supports the specified feature. The value of
560 // this varies during the lifetime of the browser. For example, if the window 563 // this varies during the lifetime of the browser. For example, if the window
561 // is fullscreen this may return a different value. If you only care about 564 // is fullscreen this may return a different value. If you only care about
562 // whether or not it's possible for the browser to support a particular 565 // whether or not it's possible for the browser to support a particular
563 // feature use |CanSupportWindowFeature|. 566 // feature use |CanSupportWindowFeature|.
564 bool SupportsWindowFeature(WindowFeature feature) const; 567 bool SupportsWindowFeature(WindowFeature feature) const;
565 568
566 // Returns true if the Browser can support the specified feature. See comment 569 // Returns true if the Browser can support the specified feature. See comment
567 // in |SupportsWindowFeature| for details on this. 570 // in |SupportsWindowFeature| for details on this.
(...skipping 389 matching lines...) Expand 10 before | Expand all | Expand 10 after
957 content::WebContents* source) OVERRIDE; 960 content::WebContents* source) OVERRIDE;
958 virtual gfx::Rect GetRootWindowResizerRect() const OVERRIDE; 961 virtual gfx::Rect GetRootWindowResizerRect() const OVERRIDE;
959 virtual void BeforeUnloadFired(content::WebContents* source, 962 virtual void BeforeUnloadFired(content::WebContents* source,
960 bool proceed, 963 bool proceed,
961 bool* proceed_to_fire_unload) OVERRIDE; 964 bool* proceed_to_fire_unload) OVERRIDE;
962 virtual void SetFocusToLocationBar(bool select_all) OVERRIDE; 965 virtual void SetFocusToLocationBar(bool select_all) OVERRIDE;
963 virtual void RenderWidgetShowing() OVERRIDE; 966 virtual void RenderWidgetShowing() OVERRIDE;
964 virtual int GetExtraRenderViewHeight() const OVERRIDE; 967 virtual int GetExtraRenderViewHeight() const OVERRIDE;
965 virtual void OnStartDownload(content::WebContents* source, 968 virtual void OnStartDownload(content::WebContents* source,
966 content::DownloadItem* download) OVERRIDE; 969 content::DownloadItem* download) OVERRIDE;
967 virtual void ShowPageInfo(content::BrowserContext* browser_context,
968 const GURL& url,
969 const content::SSLStatus& ssl,
970 bool show_history) OVERRIDE;
971 virtual void ViewSourceForTab(content::WebContents* source, 970 virtual void ViewSourceForTab(content::WebContents* source,
972 const GURL& page_url) OVERRIDE; 971 const GURL& page_url) OVERRIDE;
973 virtual void ViewSourceForFrame( 972 virtual void ViewSourceForFrame(
974 content::WebContents* source, 973 content::WebContents* source,
975 const GURL& frame_url, 974 const GURL& frame_url,
976 const std::string& frame_content_state) OVERRIDE; 975 const std::string& frame_content_state) OVERRIDE;
977 virtual bool PreHandleKeyboardEvent(const NativeWebKeyboardEvent& event, 976 virtual bool PreHandleKeyboardEvent(const NativeWebKeyboardEvent& event,
978 bool* is_keyboard_shortcut) OVERRIDE; 977 bool* is_keyboard_shortcut) OVERRIDE;
979 virtual void HandleKeyboardEvent( 978 virtual void HandleKeyboardEvent(
980 const NativeWebKeyboardEvent& event) OVERRIDE; 979 const NativeWebKeyboardEvent& event) OVERRIDE;
(...skipping 468 matching lines...) Expand 10 before | Expand all | Expand 10 after
1449 1448
1450 scoped_refptr<FullscreenController> fullscreen_controller_; 1449 scoped_refptr<FullscreenController> fullscreen_controller_;
1451 1450
1452 // True if the browser window has been shown at least once. 1451 // True if the browser window has been shown at least once.
1453 bool window_has_shown_; 1452 bool window_has_shown_;
1454 1453
1455 DISALLOW_COPY_AND_ASSIGN(Browser); 1454 DISALLOW_COPY_AND_ASSIGN(Browser);
1456 }; 1455 };
1457 1456
1458 #endif // CHROME_BROWSER_UI_BROWSER_H_ 1457 #endif // CHROME_BROWSER_UI_BROWSER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698