Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: client/dom/scripts/dartdomgenerator.py

Issue 9390009: Implement C++ bindings generation in dartgenerator.py. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Comments addressed. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/dom/idl/dart/dart.idl ('k') | client/dom/scripts/dartgenerator.py » ('j') | client/dom/scripts/dartgenerator.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/dom/scripts/dartdomgenerator.py
diff --git a/client/dom/scripts/dartdomgenerator.py b/client/dom/scripts/dartdomgenerator.py
index 70cc4a43825910d797017f8837b648c519f4fca3..950f5d95b60fdaf6e4a6ef88a42dc37e5087913c 100755
--- a/client/dom/scripts/dartdomgenerator.py
+++ b/client/dom/scripts/dartdomgenerator.py
@@ -54,8 +54,11 @@ def GenerateDOM(systems, output_dir):
'DOMStringList': 'List<String>',
})
generator.FilterMembersWithUnidentifiedTypes(common_database)
- generator.ConvertToDartTypes(common_database)
webkit_database = common_database.Clone()
+ # FIXME: get rid of _original_idl_types map in dartgenerator.py and
+ # call ConvertToDartTypes before cloning.
+ generator.ConvertToDartTypes(common_database)
+ generator.ConvertToDartTypes(webkit_database)
generated_output_dir = os.path.join(output_dir, 'generated')
if os.path.exists(generated_output_dir):
« no previous file with comments | « client/dom/idl/dart/dart.idl ('k') | client/dom/scripts/dartgenerator.py » ('j') | client/dom/scripts/dartgenerator.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698