IndexedDB: Implement IPC plumbing for IDBObjectStore.delete(IDBKeyRange)

IndexedDB: Implement IPC plumbing for IDBObjectStore.delete(IDBKeyRange)

Introduces an IndexedDBKeyRange type for simplifying IPC messages, but existing messages have not yet been changed to use it.

BUG=101384
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122567

[jsbell, 2012-02-14 00:41:00]

WebKit side (currently as a unified patch, will need to be split into a 2-sided
patch) is:

https://bugs.webkit.org/show_bug.cgi?id=78399

Note that once this has landed there's the potential for cleanup; delete(key)
could be implemented as delete(IDBKeyRange.only(key)) so the non-range methods
could be removed from Chromium.

[michaeln, 2012-02-14 20:39:33]

chrome plumbing lgtm, just some overloaded naming nits, i haven't looked at the
guts of this in the webcore side yet

https://chromiumcodereview.appspot.com/9389025/diff/1/content/renderer/indexe...
File content/renderer/indexed_db/indexed_db_dispatcher.h (right):

https://chromiumcodereview.appspot.com/9389025/diff/1/content/renderer/indexe...
content/renderer/indexed_db/indexed_db_dispatcher.h:168: void
RequestIDBObjectStoreDelete(
please rename to avoid overloading here... RequestIDBObjectStoreDeleteRange() ?

https://chromiumcodereview.appspot.com/9389025/diff/1/content/renderer/indexe...
File content/renderer/indexed_db/renderer_webidbobjectstore_impl.h (right):

https://chromiumcodereview.appspot.com/9389025/diff/1/content/renderer/indexe...
content/renderer/indexed_db/renderer_webidbobjectstore_impl.h:45: virtual void
deleteFunction(const WebKit::WebIDBKeyRange& key_range,
we generally avoid overloading method names for clarity, but if this sticks in
the webkit api... so be it

maybe deleteRangeFunction() ?

[jsbell, 2012-02-17 18:39:10]

On 2012/02/14 20:39:33, michaeln wrote:
>
https://chromiumcodereview.appspot.com/9389025/diff/1/content/renderer/indexe...
> content/renderer/indexed_db/indexed_db_dispatcher.h:168: void
> RequestIDBObjectStoreDelete(
> please rename to avoid overloading here... RequestIDBObjectStoreDeleteRange()
?

Done.
 
https://chromiumcodereview.appspot.com/9389025/diff/1/content/renderer/indexe...
> content/renderer/indexed_db/renderer_webidbobjectstore_impl.h:45: virtual void
> deleteFunction(const WebKit::WebIDBKeyRange& key_range,
> we generally avoid overloading method names for clarity, but if this sticks in
> the webkit api... so be it

I'm going to leave these as-is (following the WebKit style); eventually we can
actually collapse these all back down to a single delete(range) method since you
can have a range that's exactly one key. Introducing a second method is just for
CR/WK compatiblity while landing. (But I won't be doing that consolidation right
away.)

[commit-bot: I haz the power, 2012-02-17 18:43:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jsbell@chromium.org/9389025/3002

[commit-bot: I haz the power, 2012-02-17 20:20:28]

Change committed as 122567