Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Side by Side Diff: webkit/dom_storage/dom_storage_task_runner.cc

Issue 9389009: Hook up DomStorageArea with a DomStorageDatabase. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/dom_storage/dom_storage_task_runner.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "webkit/dom_storage/dom_storage_task_runner.h" 5 #include "webkit/dom_storage/dom_storage_task_runner.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/message_loop_proxy.h" 9 #include "base/message_loop_proxy.h"
10 10
11 namespace dom_storage { 11 namespace dom_storage {
12 12
13 // DomStorageTaskRunner 13 // DomStorageTaskRunner
14 14
15 DomStorageTaskRunner::DomStorageTaskRunner( 15 DomStorageTaskRunner::DomStorageTaskRunner(
16 base::MessageLoopProxy* message_loop) 16 base::MessageLoopProxy* message_loop)
17 : message_loop_(message_loop) { 17 : message_loop_(message_loop) {
18 } 18 }
19 19
20 DomStorageTaskRunner::~DomStorageTaskRunner() { 20 DomStorageTaskRunner::~DomStorageTaskRunner() {
21 } 21 }
22 22
23 void DomStorageTaskRunner::PostTask( 23 bool DomStorageTaskRunner::PostTask(
24 const tracked_objects::Location& from_here, 24 const tracked_objects::Location& from_here,
25 const base::Closure& task) { 25 const base::Closure& task) {
26 message_loop_->PostTask(from_here, task); 26 return message_loop_->PostTask(from_here, task);
27 } 27 }
28 28
29 void DomStorageTaskRunner::PostDelayedTask( 29 bool DomStorageTaskRunner::PostDelayedTask(
30 const tracked_objects::Location& from_here, 30 const tracked_objects::Location& from_here,
31 const base::Closure& task, 31 const base::Closure& task,
32 base::TimeDelta delay) { 32 base::TimeDelta delay) {
33 message_loop_->PostDelayedTask(from_here, task, delay.InMilliseconds()); 33 return message_loop_->PostDelayedTask(from_here, task,
34 delay.InMilliseconds());
34 } 35 }
35 36
36 // DomStorageWorkerPoolTaskRunner 37 // DomStorageWorkerPoolTaskRunner
37 38
38 DomStorageWorkerPoolTaskRunner::DomStorageWorkerPoolTaskRunner( 39 DomStorageWorkerPoolTaskRunner::DomStorageWorkerPoolTaskRunner(
39 base::SequencedWorkerPool* sequenced_worker_pool, 40 base::SequencedWorkerPool* sequenced_worker_pool,
40 base::MessageLoopProxy* delayed_task_loop) 41 base::MessageLoopProxy* delayed_task_loop)
41 : DomStorageTaskRunner(delayed_task_loop), 42 : DomStorageTaskRunner(delayed_task_loop),
42 sequenced_worker_pool_(sequenced_worker_pool), 43 sequenced_worker_pool_(sequenced_worker_pool),
43 sequence_token_( 44 sequence_token_(
44 sequenced_worker_pool->GetNamedSequenceToken("dom_storage_token")) { 45 sequenced_worker_pool->GetNamedSequenceToken("dom_storage_token")) {
45 } 46 }
46 47
47 DomStorageWorkerPoolTaskRunner::~DomStorageWorkerPoolTaskRunner() { 48 DomStorageWorkerPoolTaskRunner::~DomStorageWorkerPoolTaskRunner() {
48 } 49 }
49 50
50 void DomStorageWorkerPoolTaskRunner::PostTask( 51 bool DomStorageWorkerPoolTaskRunner::PostTask(
51 const tracked_objects::Location& from_here, 52 const tracked_objects::Location& from_here,
52 const base::Closure& task) { 53 const base::Closure& task) {
53 // TODO(michaeln): Do all tasks need to be run prior to shutdown? 54 // We can skip on shutdown as the destructor of DomStorageArea will ensure
54 // Maybe make better use of the SHUTDOWN_BEHAVIOR. 55 // that any remaining data is committed to disk.
55 sequenced_worker_pool_->PostSequencedWorkerTask( 56 return sequenced_worker_pool_->PostSequencedWorkerTaskWithShutdownBehavior(
56 sequence_token_, from_here, task); 57 sequence_token_, from_here, task,
58 base::SequencedWorkerPool::SKIP_ON_SHUTDOWN);
57 } 59 }
58 60
59 void DomStorageWorkerPoolTaskRunner::PostDelayedTask( 61 bool DomStorageWorkerPoolTaskRunner::PostDelayedTask(
60 const tracked_objects::Location& from_here, 62 const tracked_objects::Location& from_here,
61 const base::Closure& task, 63 const base::Closure& task,
62 base::TimeDelta delay) { 64 base::TimeDelta delay) {
63 // Post a task to call this->PostTask() after the delay. 65 // Post a task to call this->PostTask() after the delay.
64 message_loop_->PostDelayedTask( 66 return message_loop_->PostDelayedTask(
65 FROM_HERE, 67 FROM_HERE,
66 base::Bind(&DomStorageWorkerPoolTaskRunner::PostTask, this, 68 base::Bind(base::IgnoreResult(&DomStorageWorkerPoolTaskRunner::PostTask),
67 from_here, task), 69 this, from_here, task),
68 delay.InMilliseconds()); 70 delay.InMilliseconds());
69 } 71 }
70 72
73 // MockDomStorageTaskRunner
74
75 MockDomStorageTaskRunner::MockDomStorageTaskRunner(
76 base::MessageLoopProxy* message_loop)
77 : DomStorageTaskRunner(message_loop) {
78 }
79
80 bool MockDomStorageTaskRunner::PostDelayedTask(
81 const tracked_objects::Location& from_here,
82 const base::Closure& task,
83 base::TimeDelta delay) {
84 // Don't wait in unit tests.
85 return PostTask(from_here, task);
86 }
87
71 } // namespace dom_storage 88 } // namespace dom_storage
OLDNEW
« no previous file with comments | « webkit/dom_storage/dom_storage_task_runner.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698