Hook up DomStorageArea with a DomStorageDatabase.

webkit/dom_storage/dom_storage_task_runner.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/dom_storage/dom_storage_task_runner.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/message_loop_proxy.h"
 
 namespace dom_storage {
 
 // DomStorageTaskRunner
 
 DomStorageTaskRunner::DomStorageTaskRunner(
     base::MessageLoopProxy* message_loop)
     : message_loop_(message_loop) {
 }
 
 DomStorageTaskRunner::~DomStorageTaskRunner() {
 }
 
-void DomStorageTaskRunner::PostTask(
+bool DomStorageTaskRunner::PostTask(
     const tracked_objects::Location& from_here,
     const base::Closure& task) {
-  message_loop_->PostTask(from_here, task);
+  return message_loop_->PostTask(from_here, task);
 }
 
-void DomStorageTaskRunner::PostDelayedTask(
+bool DomStorageTaskRunner::PostDelayedTask(
     const tracked_objects::Location& from_here,
     const base::Closure& task,
     base::TimeDelta delay) {
-  message_loop_->PostDelayedTask(from_here, task, delay.InMilliseconds());
+  return message_loop_->PostDelayedTask(from_here, task,
+                                        delay.InMilliseconds());
 }
 
 // DomStorageWorkerPoolTaskRunner
 
 DomStorageWorkerPoolTaskRunner::DomStorageWorkerPoolTaskRunner(
     base::SequencedWorkerPool* sequenced_worker_pool,
     base::MessageLoopProxy* delayed_task_loop)
     : DomStorageTaskRunner(delayed_task_loop),
       sequenced_worker_pool_(sequenced_worker_pool),
       sequence_token_(
           sequenced_worker_pool->GetNamedSequenceToken("dom_storage_token")) {
 }
 
 DomStorageWorkerPoolTaskRunner::~DomStorageWorkerPoolTaskRunner() {
 }
 
-void DomStorageWorkerPoolTaskRunner::PostTask(
+bool DomStorageWorkerPoolTaskRunner::PostTask(
     const tracked_objects::Location& from_here,
     const base::Closure& task) {
-  // TODO(michaeln): Do all tasks need to be run prior to shutdown?
-  // Maybe make better use of the SHUTDOWN_BEHAVIOR.
-  sequenced_worker_pool_->PostSequencedWorkerTask(
-      sequence_token_, from_here, task);
+  // We can skip on shutdown as the destructor of DomStorageArea will ensure
+  // that any remaining data is committed to disk.
+  return sequenced_worker_pool_->PostSequencedWorkerTaskWithShutdownBehavior(
+      sequence_token_, from_here, task,
+      base::SequencedWorkerPool::SKIP_ON_SHUTDOWN);
 }
 
-void DomStorageWorkerPoolTaskRunner::PostDelayedTask(
+bool DomStorageWorkerPoolTaskRunner::PostDelayedTask(
     const tracked_objects::Location& from_here,
     const base::Closure& task,
     base::TimeDelta delay) {
   // Post a task to call this->PostTask() after the delay.
-  message_loop_->PostDelayedTask(
+  return message_loop_->PostDelayedTask(
       FROM_HERE,
-      base::Bind(&DomStorageWorkerPoolTaskRunner::PostTask, this,
+      base::Bind(&DomStorageWorkerPoolTaskRunner::PostTaskVoid, this,
                  from_here, task),
       delay.InMilliseconds());
 }
 
+void DomStorageWorkerPoolTaskRunner::PostTaskVoid(
+    const tracked_objects::Location& from_here,
+    const base::Closure& task) {
+    ignore_result(PostTask(from_here, task));

[michaeln, 2012/02/23 05:15:29]

Did you try base::IgnoreResult (see example usage below)? If that doesn't work
for some reason, let's not add ignore_result here.

http://code.google.com/p/chromium/source/search?q=base%3A%3AIgnoreResult&orig...

[benm (inactive), 2012/02/23 12:27:40]

Oh cool, I didn't notice there were two ignoreresults. Will fix up.

+}
+
 }  // namespace dom_storage