Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 9389001: Optimize call sites that only ever see a single elements transition (Closed)

Created:
8 years, 10 months ago by danno
Modified:
8 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Optimize call sites that only ever see a single elements transition R=jkummerow@chromium.org TEST=imaging-gaussian-blur performance improves Committed: https://code.google.com/p/v8/source/detail?r=10683

Patch Set 1 #

Patch Set 2 : Remove whitespace #

Total comments: 3

Patch Set 3 : review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -8 lines) Patch
M src/ic.cc View 1 2 2 chunks +26 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
danno
8 years, 10 months ago (2012-02-13 08:32:41 UTC) #1
Jakob Kummerow
8 years, 10 months ago (2012-02-13 10:50:57 UTC) #2
LGTM with comments.

https://chromiumcodereview.appspot.com/9389001/diff/3001/src/ic.cc
File src/ic.cc (right):

https://chromiumcodereview.appspot.com/9389001/diff/3001/src/ic.cc#newcode1515
src/ic.cc:1515: // The first time there's an element transition, assume the new
Suggestion:
s/The first time there's an element transition/The first time a receiver is seen
that is a transitioned version of the previous monomorphic receiver type/
Otherwise it sounds like the transition happens at this IC here.

https://chromiumcodereview.appspot.com/9389001/diff/3001/src/ic.cc#newcode1520
src/ic.cc:1520: // support both the untransitioned and transition maps.
s/transition/transitioned/

https://chromiumcodereview.appspot.com/9389001/diff/3001/src/ic.cc#newcode1545
src/ic.cc:1545: if (ic_state == UNINITIALIZED || ic_state == PREMONOMORPHIC) {
I think we don't need this if-block anymore. Note that the same thing is done
unconditionally in the next line, and the only case where not setting the
map_added flag would make a difference (UNINITIALIZED target with
non-transitioning stub_kind) is already handled above.

Powered by Google App Engine
This is Rietveld 408576698