Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: chrome/browser/aeropeek_manager.cc

Issue 9387027: Revert 121840 - Make scoped dc objects smarter (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/win/scoped_hdc_unittest.cc ('k') | chrome/browser/ui/window_snapshot/window_snapshot_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/aeropeek_manager.cc
===================================================================
--- chrome/browser/aeropeek_manager.cc (revision 121842)
+++ chrome/browser/aeropeek_manager.cc (working copy)
@@ -211,7 +211,7 @@
// We can delete this DIB after sending it to Windows since Windows creates
// a copy of the DIB and use it.
base::win::ScopedCreateDC hdc(CreateCompatibleDC(NULL));
- if (!hdc.get()) {
+ if (!hdc.Get()) {
LOG(ERROR) << "cannot create a memory DC: " << GetLastError();
return;
}
@@ -222,7 +222,7 @@
void* bitmap_data = NULL;
base::win::ScopedBitmap bitmap(
- CreateDIBSection(hdc.get(), reinterpret_cast<BITMAPINFO*>(&header),
+ CreateDIBSection(hdc, reinterpret_cast<BITMAPINFO*>(&header),
DIB_RGB_COLORS, &bitmap_data, NULL, 0));
if (!bitmap.Get() || !bitmap_data) {
@@ -274,7 +274,7 @@
// We don't need to paste this tab image onto the frame image since Windows
// automatically pastes it for us.
base::win::ScopedCreateDC hdc(CreateCompatibleDC(NULL));
- if (!hdc.get()) {
+ if (!hdc.Get()) {
LOG(ERROR) << "cannot create a memory DC: " << GetLastError();
return;
}
@@ -285,7 +285,7 @@
void* bitmap_data = NULL;
base::win::ScopedBitmap bitmap(
- CreateDIBSection(hdc.get(), reinterpret_cast<BITMAPINFO*>(&header),
+ CreateDIBSection(hdc.Get(), reinterpret_cast<BITMAPINFO*>(&header),
DIB_RGB_COLORS, &bitmap_data, NULL, 0));
if (!bitmap.Get() || !bitmap_data) {
LOG(ERROR) << "cannot create a bitmap: " << GetLastError();
« no previous file with comments | « base/win/scoped_hdc_unittest.cc ('k') | chrome/browser/ui/window_snapshot/window_snapshot_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698