Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 9387023: Revert 121810 - Move SpeechRecognizer delegate into its own header file and put it in the content... (Closed)

Created:
8 years, 10 months ago by rvargas (doing something else)
Modified:
8 years, 10 months ago
Reviewers:
tfarina
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, mihaip+watch_chromium.org, Aaron Boodman
Visibility:
Public.

Description

Revert 121810 - Move SpeechRecognizer delegate into its own header file and put it in the content namespace. This avoids having a nested class as it leads to too many includes in headers. BUG=98716 R=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/9390007 TBR=tfarina@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121819

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -115 lines) Patch
M chrome/browser/speech/speech_input_extension_apitest.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/speech/speech_input_extension_manager.h View 5 chunks +5 lines, -13 lines 0 comments Download
M chrome/browser/speech/speech_input_extension_manager.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/speech/speech_input_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/speech/speech_input_manager.h View 2 chunks +3 lines, -12 lines 0 comments Download
M content/browser/speech/speech_input_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/speech/speech_recognizer.h View 6 chunks +60 lines, -9 lines 0 comments Download
M content/browser/speech/speech_recognizer.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M content/browser/speech/speech_recognizer_unittest.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D content/public/browser/speech_recognizer_delegate.h View 1 chunk +0 lines, -65 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
rvargas (doing something else)
8 years, 10 months ago (2012-02-14 02:15:56 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698