Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4979)

Unified Diff: chrome/browser/resources/options2/options_page.js

Issue 9386032: [uber page] Migrate the virtual keyboard sub-page to a dialog (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options2/options_page.js
diff --git a/chrome/browser/resources/options2/options_page.js b/chrome/browser/resources/options2/options_page.js
index 7b16dcc89f86af5ed44e868e2708fbb828eb9e41..ca855c8a4253e495ff206f91ae9aad87e513360e 100644
--- a/chrome/browser/resources/options2/options_page.js
+++ b/chrome/browser/resources/options2/options_page.js
@@ -294,12 +294,15 @@ cr.define('options', function() {
* @return {OptionPage} The visible overlay.
*/
OptionsPage.getVisibleOverlay_ = function() {
+ var highestPage = null;
James Hawkins 2012/02/14 21:55:03 topmostPage
Dan Beam 2012/02/14 21:58:52 Done.
for (var name in this.registeredOverlayPages) {
var page = this.registeredOverlayPages[name];
- if (page.visible)
- return page;
+ if (page.visible &&
+ (!highestPage || page.nestingLevel > highestPage.nestingLevel)) {
+ highestPage = page;
+ }
}
- return null;
+ return highestPage;
};
/**

Powered by Google App Engine
This is Rietveld 408576698