Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 9386032: [uber page] Migrate the virtual keyboard sub-page to a dialog (Closed)

Created:
8 years, 10 months ago by Dan Beam
Modified:
8 years, 10 months ago
CC:
chromium-reviews, arv (Not doing code reviews), James Hawkins, csilv
Visibility:
Public.

Description

[uber page] Migrate the virtual keyboard sub-page to a dialog This also fixes a bug in OptionPage.getVisibleOverlay_ that assumes the first overlay we find that's visible is the showing overlay (but doesn't account for the nesting level of that overlay) as well as a language overlay confirm bug. BUG=111685 TEST=./build/gyp_chromium -Duse_virtual_keyboard=1 -Dchromeos=1 -Duse_ibus=0 -Duse_aura=1 and open Advanced > Language settings > Keyboard and then actually close language settings. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121965

Patch Set 1 #

Total comments: 3

Patch Set 2 : var rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -28 lines) Patch
M chrome/browser/resources/options2/chromeos/virtual_keyboard.html View 1 chunk +15 lines, -8 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/virtual_keyboard.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/options2/language_options.js View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/resources/options2/options.html View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/options2/options.js View 2 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/resources/options2/options_page.js View 1 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Dan Beam
any options2 OWNER can review this
8 years, 10 months ago (2012-02-14 03:37:49 UTC) #1
Dan Beam
+estade, -jhawkins/csilv
8 years, 10 months ago (2012-02-14 18:46:03 UTC) #2
Evan Stade
lgtm https://chromiumcodereview.appspot.com/9386032/diff/1/chrome/browser/resources/options2/chromeos/virtual_keyboard.html File chrome/browser/resources/options2/chromeos/virtual_keyboard.html (right): https://chromiumcodereview.appspot.com/9386032/diff/1/chrome/browser/resources/options2/chromeos/virtual_keyboard.html#newcode1 chrome/browser/resources/options2/chromeos/virtual_keyboard.html:1: <div id="virtual-keyboard-manager" class="page" hidden> should the file be ...
8 years, 10 months ago (2012-02-14 19:20:39 UTC) #3
Dan Beam
Yes, but I think this needs to be done on a bigger scale as there ...
8 years, 10 months ago (2012-02-14 21:33:53 UTC) #4
James Hawkins
https://chromiumcodereview.appspot.com/9386032/diff/1/chrome/browser/resources/options2/options_page.js File chrome/browser/resources/options2/options_page.js (right): https://chromiumcodereview.appspot.com/9386032/diff/1/chrome/browser/resources/options2/options_page.js#newcode297 chrome/browser/resources/options2/options_page.js:297: var highestPage = null; topmostPage
8 years, 10 months ago (2012-02-14 21:55:03 UTC) #5
Dan Beam
https://chromiumcodereview.appspot.com/9386032/diff/1/chrome/browser/resources/options2/options_page.js File chrome/browser/resources/options2/options_page.js (right): https://chromiumcodereview.appspot.com/9386032/diff/1/chrome/browser/resources/options2/options_page.js#newcode297 chrome/browser/resources/options2/options_page.js:297: var highestPage = null; On 2012/02/14 21:55:03, James Hawkins ...
8 years, 10 months ago (2012-02-14 21:58:52 UTC) #6
James Hawkins
lgtm
8 years, 10 months ago (2012-02-14 22:00:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/9386032/3002
8 years, 10 months ago (2012-02-14 22:00:55 UTC) #8
commit-bot: I haz the power
8 years, 10 months ago (2012-02-14 23:28:31 UTC) #9
Change committed as 121965

Powered by Google App Engine
This is Rietveld 408576698