base/files/file_path_watcher_browsertest.cc - Issue 9386014: Flakiness cleanup: disable flaky tests under base/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/files/file_path_watcher_browsertest.cc

Issue 9386014: Flakiness cleanup: disable flaky tests under base/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/files/file_path_watcher_browsertest.cc

diff --git a/base/files/file_path_watcher_browsertest.cc b/base/files/file_path_watcher_browsertest.cc

index f0f789a9f04e59a072f954f5cf4f1eac568410f2..e7593adf07bcb65f093f07df8f18b6eb973101e8 100644

--- a/base/files/file_path_watcher_browsertest.cc

+++ b/base/files/file_path_watcher_browsertest.cc

@@ -270,7 +270,7 @@ TEST_F(FilePathWatcherTest, DeleteDuringNotify) {

// notification.

// Flaky on MacOS. http://crbug.com/85930

#if defined(OS_MACOSX)

-#define MAYBE_DestroyWithPendingNotification FLAKY_DestroyWithPendingNotification

+#define MAYBE_DestroyWithPendingNotification DISABLED_DestroyWithPendingNotification

#else

#define MAYBE_DestroyWithPendingNotification DestroyWithPendingNotification

#endif

@@ -352,7 +352,7 @@ TEST_F(FilePathWatcherTest, DirectoryChain) {

#if defined(OS_MACOSX)

// http://crbug.com/85930

-#define DisappearingDirectory FLAKY_DisappearingDirectory

+#define DisappearingDirectory DISABLED_DisappearingDirectory

#endif

TEST_F(FilePathWatcherTest, DisappearingDirectory) {

FilePathWatcher watcher;

« no previous file with comments | « base/file_util_unittest.cc ('k') | base/metrics/stats_table_unittest.cc » ('j') | no next file with comments »