Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1107)

Unified Diff: chrome/renderer/resources/extensions/schema_generated_bindings.js

Issue 9386001: Implement a module system for the extension bindings JS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/schema_generated_bindings.js
diff --git a/chrome/renderer/resources/extensions/schema_generated_bindings.js b/chrome/renderer/resources/extensions/schema_generated_bindings.js
index bc057d2eb4c48cc6179b602963cb1f8b275b2609..ab119234c1103ff8301fec0c80a1631b08380efe 100644
--- a/chrome/renderer/resources/extensions/schema_generated_bindings.js
+++ b/chrome/renderer/resources/extensions/schema_generated_bindings.js
@@ -5,15 +5,15 @@
// This script contains privileged chrome extension related javascript APIs.
// It is loaded by pages whose URL has the chrome-extension protocol.
-var chrome = chrome || {};
-(function() {
- native function GetChromeHidden();
- native function GetExtensionAPIDefinition();
- native function GetNextRequestId();
- native function StartRequest();
- native function SetIconCommon();
+ require('json_schema');
+ require('event_bindings');
+ var natives = requireNative('schema_generated_bindings');
+ var GetExtensionAPIDefinition = natives.GetExtensionAPIDefinition;
+ var GetNextRequestId = natives.GetNextRequestId;
+ var StartRequest = natives.StartRequest;
+ var SetIconCommon = natives.SetIconCommon;
- var chromeHidden = GetChromeHidden();
+ var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
// The object to generate the bindings for "internal" APIs in, so that
// extensions can't directly call them (without access to chromeHidden),
@@ -753,4 +753,3 @@ var chrome = chrome || {};
if (chrome.test)
chrome.test.getApiDefinitions = GetExtensionAPIDefinition;
});
-})();

Powered by Google App Engine
This is Rietveld 408576698