chrome/renderer/resources/extensions/page_action_custom_bindings.js - Issue 9386001: Implement a module system for the extension bindings JS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/page_action_custom_bindings.js

Issue 9386001: Implement a module system for the extension bindings JS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/omnibox_custom_bindings.js ('k') | chrome/renderer/resources/extensions/page_actions_custom_bindings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/page_action_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/page_action_custom_bindings.js b/chrome/renderer/resources/extensions/page_action_custom_bindings.js

index 722a57b0bded6fe8b1a34d7cf086533ad48a25ee..13336b1d41ddf0bc7f04d7d621210a8f70a39efb 100644

--- a/chrome/renderer/resources/extensions/page_action_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/page_action_custom_bindings.js

@@ -4,11 +4,9 @@

// Custom bindings for the pageAction API.

-(function() {

+var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();

-native function GetChromeHidden();

-GetChromeHidden().registerCustomHook('pageAction', function(bindingsAPI) {

+chromeHidden.registerCustomHook('pageAction', function(bindingsAPI) {

var apiFunctions = bindingsAPI.apiFunctions;

var setIcon = bindingsAPI.setIcon;

@@ -16,5 +14,3 @@ GetChromeHidden().registerCustomHook('pageAction', function(bindingsAPI) {

setIcon(details, this.name, this.definition.parameters, 'page action');

});

-})();