Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5981)

Unified Diff: chrome/renderer/extensions/web_request_custom_bindings.cc

Issue 9386001: Implement a module system for the extension bindings JS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/web_request_custom_bindings.cc
diff --git a/chrome/renderer/extensions/web_request_custom_bindings.cc b/chrome/renderer/extensions/web_request_custom_bindings.cc
index 32469268fbcd6871e1cbdc9904266d7da4eca2f7..83f716c7f2c85bef161f9273899c45350985288e 100644
--- a/chrome/renderer/extensions/web_request_custom_bindings.cc
+++ b/chrome/renderer/extensions/web_request_custom_bindings.cc
@@ -12,18 +12,15 @@
namespace extensions {
-WebRequestCustomBindings::WebRequestCustomBindings(
- int dependency_count,
- const char** dependencies)
- : ChromeV8Extension(
- "extensions/web_request_custom_bindings.js",
- IDR_WEB_REQUEST_CUSTOM_BINDINGS_JS,
- dependency_count,
- dependencies,
- NULL) {}
+WebRequestCustomBindings::WebRequestCustomBindings()
+ : ChromeV8Extension(NULL) {
+ RouteStaticFunction("GetUniqueSubEventName", &GetUniqueSubEventName);
+}
// Attach an event name to an object.
-static v8::Handle<v8::Value> GetUniqueSubEventName(const v8::Arguments& args) {
+// static
+v8::Handle<v8::Value> WebRequestCustomBindings::GetUniqueSubEventName(
+ const v8::Arguments& args) {
static int next_event_id = 0;
DCHECK(args.Length() == 1);
DCHECK(args[0]->IsString());
@@ -33,13 +30,5 @@ static v8::Handle<v8::Value> GetUniqueSubEventName(const v8::Arguments& args) {
return v8::String::New(unique_event_name.c_str());
}
-v8::Handle<v8::FunctionTemplate> WebRequestCustomBindings::GetNativeFunction(
- v8::Handle<v8::String> name) {
- if (name->Equals(v8::String::New("GetUniqueSubEventName")))
- return v8::FunctionTemplate::New(GetUniqueSubEventName);
-
- return ChromeV8Extension::GetNativeFunction(name);
-}
-
} // extensions
« no previous file with comments | « chrome/renderer/extensions/web_request_custom_bindings.h ('k') | chrome/renderer/extensions/webstore_bindings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698