Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: chrome/renderer/extensions/page_capture_custom_bindings.cc

Issue 9386001: Implement a module system for the extension bindings JS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/page_capture_custom_bindings.cc
diff --git a/chrome/renderer/extensions/page_capture_custom_bindings.cc b/chrome/renderer/extensions/page_capture_custom_bindings.cc
index e37cdab0667e0defbe4678ff4818097e061a577b..c7e41ead3a1714fbbe30bf7f6717220ba713875f 100644
--- a/chrome/renderer/extensions/page_capture_custom_bindings.cc
+++ b/chrome/renderer/extensions/page_capture_custom_bindings.cc
@@ -13,18 +13,15 @@
namespace extensions {
-PageCaptureCustomBindings::PageCaptureCustomBindings(
- int dependency_count,
- const char** dependencies)
- : ChromeV8Extension(
- "extensions/page_capture_custom_bindings.js",
- IDR_PAGE_CAPTURE_CUSTOM_BINDINGS_JS,
- dependency_count,
- dependencies,
- NULL) {}
-
-// Creates a Blob with the content of the specified file.
-static v8::Handle<v8::Value> CreateBlob(const v8::Arguments& args) {
+PageCaptureCustomBindings::PageCaptureCustomBindings()
+ : ChromeV8Extension(NULL) {
+ RouteStaticFunction("CreateBlob", &CreateBlob);
+ RouteStaticFunction("SendResponseAck", &SendResponseAck);
+}
+
+// static
+v8::Handle<v8::Value> PageCaptureCustomBindings::CreateBlob(
+ const v8::Arguments& args) {
CHECK(args.Length() == 2);
CHECK(args[0]->IsString());
CHECK(args[1]->IsInt32());
@@ -48,15 +45,4 @@ v8::Handle<v8::Value> PageCaptureCustomBindings::SendResponseAck(
return v8::Undefined();
}
-v8::Handle<v8::FunctionTemplate> PageCaptureCustomBindings::GetNativeFunction(
- v8::Handle<v8::String> name) {
- if (name->Equals(v8::String::New("CreateBlob"))) {
- return v8::FunctionTemplate::New(CreateBlob, v8::External::New(this));
- } else if (name->Equals(v8::String::New("SendResponseAck"))) {
- return v8::FunctionTemplate::New(SendResponseAck, v8::External::New(this));
- }
-
- return ChromeV8Extension::GetNativeFunction(name);
-}
-
} // namespace extensions
« no previous file with comments | « chrome/renderer/extensions/page_capture_custom_bindings.h ('k') | chrome/renderer/extensions/schema_generated_bindings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698