Implement a module system for the extension bindings JS.

chrome/renderer/resources/require.js

Index: chrome/renderer/resources/require.js
diff --git a/chrome/renderer/resources/require.js b/chrome/renderer/resources/require.js
index 34f3543a432fe5bcd2348aaf24c2e3b270b0eff9..ad865a7bf69db5b0f438ae0111a594f56b25c38e 100644
--- a/chrome/renderer/resources/require.js
+++ b/chrome/renderer/resources/require.js
@@ -34,7 +34,7 @@ ModuleLoader.prototype.run = function(id) {
     return null;
   }
   var wrappedSource = wrap(source);

[Aaron Boodman, 2012/03/01 07:24:26]

Unless v8 does something fancy internally, it seems like this will end up making
a copy of the big string that you went to such trouble to avoid allocating in
the first place.

If you just required the modules to be wrapped in the source, it would avoid
this problem, and you could make the interface between require.js and
ModuleSystem a bit simpler by just having Run(id), not GetSource(id) and
Run(id).

Alternately, there could be some build-time magic to do the wrapping. Or, we
could just say screw it and allocate the strings once and cache them across the
process thereafter.

[Aaron Boodman, 2012/03/01 07:30:32]

I feel pretty strongly that the right answer here is to wrap the code within the
source of each module. That would simplify things.

[koz (OOO until 15th September), 2012/03/02 01:13:58]

As discussed, I've reimplemented with "new Function(...)" on the JS side.

-  var f = bootstrap.Run(wrappedSource);
+  var f = bootstrap.Run(wrappedSource, id);
   var exports = {};
   f(require, requireNative, exports);
   return exports;
@@ -53,7 +53,11 @@ ModuleLoader.prototype.load = function(id) {
 var moduleLoader = new ModuleLoader();
 
 function requireNative(nativeName) {
-  return bootstrap.GetNative(nativeName);
+  var result = bootstrap.GetNative(nativeName);
+  if (!result) {
+    throw "No such native object: '" + nativeName + "'";
+  }
+  return result;
 }
 
 function require(moduleId) {