chrome/renderer/resources/extensions/page_actions_custom_bindings.js - Issue 9386001: Implement a module system for the extension bindings JS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/page_actions_custom_bindings.js

Issue 9386001: Implement a module system for the extension bindings JS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix compile errors Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/module_system.h ('K') | « chrome/renderer/resources/extensions/page_action_custom_bindings.js ('k') | chrome/renderer/resources/extensions/page_capture_custom_bindings.js » ('j') | chrome/renderer/resources/extensions/setup_bindings.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/page_actions_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/page_actions_custom_bindings.js b/chrome/renderer/resources/extensions/page_actions_custom_bindings.js

index 2a7a2debfcbd6f5cc9af8fb1a594115621556242..5797e8547d70acf9802a3cb9f6250dff7cf3b0c6 100644

--- a/chrome/renderer/resources/extensions/page_actions_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/page_actions_custom_bindings.js

@@ -6,11 +6,13 @@

(function() {

-native function GetChromeHidden();

-native function GetCurrentPageActions();

+var pageActionsNatives = requireNative('page_actions');

+var GetCurrentPageActions = pageActionsNatives.GetCurrentPageActions;

-GetChromeHidden().registerCustomHook('pageActions',

- function(bindingsAPI, extensionId) {

+var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();

+chromeHidden.registerCustomHook('pageActions',

+ function(bindingsAPI, extensionId) {

var pageActions = GetCurrentPageActions(extensionId);

var oldStyleEventName = 'pageActions';

for (var i = 0; i < pageActions.length; ++i) {