Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9747)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/renderer/resources/extensions/extension_custom_bindings.js

Issue 9386001: Implement a module system for the extension bindings JS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix compile errors Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/renderer/module_system.h ('K') | « chrome/renderer/resources/extensions/experimental.socket_custom_bindings.js ('k') | chrome/renderer/resources/extensions/file_browser_handler_custom_bindings.js » ('j') | chrome/renderer/resources/extensions/setup_bindings.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/extensions/extension_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/extension_custom_bindings.js b/chrome/renderer/resources/extensions/extension_custom_bindings.js
index 1546aad3e6a2452377a3d0d621184cfc3dd1dd10..dc371e8b28cc9ac165b35f35e68aa9826388cd1a 100644
--- a/chrome/renderer/resources/extensions/extension_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/extension_custom_bindings.js
@@ -6,11 +6,11 @@
(function() {
-native function GetChromeHidden();
-native function GetExtensionViews();
-native function OpenChannelToExtension(sourceId, targetId, name);
+var extensionNatives = requireNative('extension');
+var GetExtensionViews = extensionNatives.GetExtensionViews;
+var OpenChannelToExtension = extensionNatives.OpenChannelToExtension;
-var chromeHidden = GetChromeHidden();
+var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
// This should match chrome.windows.WINDOW_ID_NONE.
//
« chrome/renderer/module_system.h ('K') | « chrome/renderer/resources/extensions/experimental.socket_custom_bindings.js ('k') | chrome/renderer/resources/extensions/file_browser_handler_custom_bindings.js » ('j') | chrome/renderer/resources/extensions/setup_bindings.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698