Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3471)

Unified Diff: chrome/renderer/native_handler.h

Issue 9386001: Implement a module system for the extension bindings JS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix compile errors Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/native_handler.h
diff --git a/chrome/renderer/native_handler.h b/chrome/renderer/native_handler.h
index b4d3078ef1ea96fa16a9409d73c4c9c70a59e42c..4ee88fe6ee44bed332a21da0e9054e5b7e02e556 100644
--- a/chrome/renderer/native_handler.h
+++ b/chrome/renderer/native_handler.h
@@ -16,6 +16,7 @@
// A NativeHandler is a factory for JS objects with functions on them that map
// to native C++ functions. Subclasses should call RouteFunction() in their
// constructor to define functions on the created JS objects.
+// TODO(koz): Rename this to NativeJavaScriptModule.
class NativeHandler {
public:
explicit NativeHandler();
@@ -26,6 +27,7 @@ class NativeHandler {
v8::Handle<v8::Object> NewInstance();
protected:
+ typedef v8::Handle<v8::Value> (*HandlerFunc)(const v8::Arguments&);
typedef base::Callback<v8::Handle<v8::Value>(const v8::Arguments&)>
HandlerFunction;
@@ -35,6 +37,9 @@ class NativeHandler {
void RouteFunction(const std::string& name,
const HandlerFunction& handler_function);
+ void RouteStaticFunction(const std::string& name,
+ const HandlerFunc handler_func);
+
private:
static v8::Handle<v8::Value> Router(const v8::Arguments& args);

Powered by Google App Engine
This is Rietveld 408576698