chrome/renderer/resources/extensions/tabs_custom_bindings.js - Issue 9386001: Implement a module system for the extension bindings JS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/tabs_custom_bindings.js

Issue 9386001: Implement a module system for the extension bindings JS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: re-jigged to use ModuleSystem Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/resources/extensions/tabs_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/tabs_custom_bindings.js b/chrome/renderer/resources/extensions/tabs_custom_bindings.js

index f67f6692b40d5c501d9b7b56a53a3102bf879f1c..1a5404b7f7e6e62593487366da99a87bd09433c0 100644

--- a/chrome/renderer/resources/extensions/tabs_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/tabs_custom_bindings.js

@@ -6,10 +6,10 @@

(function() {

-native function GetChromeHidden();

-native function OpenChannelToTab();

+var tabs = requireNative('tabs');

+var OpenChannelToTab = tabs.OpenChannelToTab;

-var chromeHidden = GetChromeHidden();

+var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();

chromeHidden.registerCustomHook('tabs', function(bindingsAPI, extensionId) {

var apiFunctions = bindingsAPI.apiFunctions;