chrome/renderer/resources/extensions/devtools_custom_bindings.js - Issue 9386001: Implement a module system for the extension bindings JS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/devtools_custom_bindings.js

Issue 9386001: Implement a module system for the extension bindings JS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: re-jigged to use ModuleSystem Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/resources/extensions/devtools_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/devtools_custom_bindings.js b/chrome/renderer/resources/extensions/devtools_custom_bindings.js

index a0e0a3fe9b15ddff458bcdf523a1f583c0cce194..95c6ba571e7295d90411abb0a765f6e427316dd1 100644

--- a/chrome/renderer/resources/extensions/devtools_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/devtools_custom_bindings.js

@@ -6,9 +6,9 @@

(function() {

-native function GetChromeHidden();

+var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();

-GetChromeHidden().registerCustomHook('devtools', function(bindingsAPI) {

+chromeHidden.registerCustomHook('devtools', function(bindingsAPI) {

var apiFunctions = bindingsAPI.apiFunctions;

apiFunctions.setHandleRequest('devtools.getTabEvents', function(tabId) {