chrome/renderer/resources/extensions/chrome_private_custom_bindings.js - Issue 9386001: Implement a module system for the extension bindings JS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/chrome_private_custom_bindings.js

Issue 9386001: Implement a module system for the extension bindings JS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: re-jigged to use ModuleSystem Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/native_handler.cc ('K') | « chrome/renderer/resources/extensions/browser_action_custom_bindings.js ('k') | chrome/renderer/resources/extensions/content_settings_custom_bindings.js » ('j') | chrome/renderer/resources/extensions/context_menus_custom_bindings.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/chrome_private_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/chrome_private_custom_bindings.js b/chrome/renderer/resources/extensions/chrome_private_custom_bindings.js

index 3a98b993e06542c9bb64db7496ff98d48d6f5944..d777d732bdd0d674d3928a311d67d8f60a2b25de 100644

--- a/chrome/renderer/resources/extensions/chrome_private_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/chrome_private_custom_bindings.js

@@ -6,10 +6,12 @@

(function() {

-native function GetChromeHidden();

-native function DecodeJPEG(jpegImage);

+var chrome_private = requireNative('chrome_private');

Aaron Boodman 2012/02/28 02:42:59 We don't usually use unix_hacker style names in Ja

koz (OOO until 15th September) 2012/03/01 03:41:56 Fixed here and elsewhere.

+var DecodeJPEG = chrome_private.DecodeJPEG;

-GetChromeHidden().registerCustomHook('chromePrivate', function(bindingsAPI) {

+var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();

+chromeHidden.registerCustomHook('chromePrivate', function(bindingsAPI) {

var apiFunctions = bindingsAPI.apiFunctions;

apiFunctions.setHandleRequest(