Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: chrome/renderer/extensions/miscellaneous_bindings.cc

Issue 9386001: Implement a module system for the extension bindings JS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: re-jigged to use ModuleSystem Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/miscellaneous_bindings.cc
diff --git a/chrome/renderer/extensions/miscellaneous_bindings.cc b/chrome/renderer/extensions/miscellaneous_bindings.cc
index 76af216311b0aaa5f85696637738256403f4acdc..174d904e43d160fb855c9d342fba2b12fdd6fbb8 100644
--- a/chrome/renderer/extensions/miscellaneous_bindings.cc
+++ b/chrome/renderer/extensions/miscellaneous_bindings.cc
@@ -62,31 +62,18 @@ static void ClearPortData(int port_id) {
}
const char kPortClosedError[] = "Attempting to use a disconnected port object";
-const char* kExtensionDeps[] = { "extensions/event.js" };
class ExtensionImpl : public ChromeV8Extension {
public:
explicit ExtensionImpl(ExtensionDispatcher* dispatcher)
- : ChromeV8Extension("extensions/miscellaneous_bindings.js",
- IDR_MISCELLANEOUS_BINDINGS_JS,
- arraysize(kExtensionDeps), kExtensionDeps,
- dispatcher) {
+ : ChromeV8Extension(dispatcher) {
+ RouteStaticFunction("CloseChannel", &CloseChannel);
+ RouteStaticFunction("PortAddRef", &PortAddRef);
+ RouteStaticFunction("PortRelease", &PortRelease);
+ RouteStaticFunction("PostMessage", &PostMessage);
}
- ~ExtensionImpl() {}
- virtual v8::Handle<v8::FunctionTemplate> GetNativeFunction(
- v8::Handle<v8::String> name) {
- if (name->Equals(v8::String::New("PostMessage"))) {
- return v8::FunctionTemplate::New(PostMessage);
- } else if (name->Equals(v8::String::New("CloseChannel"))) {
- return v8::FunctionTemplate::New(CloseChannel);
- } else if (name->Equals(v8::String::New("PortAddRef"))) {
- return v8::FunctionTemplate::New(PortAddRef);
- } else if (name->Equals(v8::String::New("PortRelease"))) {
- return v8::FunctionTemplate::New(PortRelease);
- }
- return ChromeV8Extension::GetNativeFunction(name);
- }
+ ~ExtensionImpl() {}
// Sends a message along the given channel.
static v8::Handle<v8::Value> PostMessage(const v8::Arguments& args) {
@@ -155,9 +142,8 @@ class ExtensionImpl : public ChromeV8Extension {
namespace extensions {
-v8::Extension* MiscellaneousBindings::Get(ExtensionDispatcher* dispatcher) {
- static v8::Extension* extension = new ExtensionImpl(dispatcher);
- return extension;
+ChromeV8Extension* MiscellaneousBindings::Get(ExtensionDispatcher* dispatcher) {
+ return new ExtensionImpl(dispatcher);
}
void MiscellaneousBindings::DeliverMessage(

Powered by Google App Engine
This is Rietveld 408576698