Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2836)

Unified Diff: chrome/renderer/extensions/custom_bindings_util.cc

Issue 9386001: Implement a module system for the extension bindings JS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/custom_bindings_util.cc
diff --git a/chrome/renderer/extensions/custom_bindings_util.cc b/chrome/renderer/extensions/custom_bindings_util.cc
index 08fb52397b94e569bf832ebdb61663e84b184297..ecbf43d9faa50debc91d22fc8a33c0a0055b6c06 100644
--- a/chrome/renderer/extensions/custom_bindings_util.cc
+++ b/chrome/renderer/extensions/custom_bindings_util.cc
@@ -29,7 +29,8 @@ namespace extensions {
namespace custom_bindings_util {
-std::vector<v8::Extension*> GetAll(ExtensionDispatcher* extension_dispatcher) {
+std::vector<ChromeV8Extension*> GetAll(
+ ExtensionDispatcher* extension_dispatcher) {
// Must match kResourceIDs.
static const char* kJavascriptFiles[] = {
"extensions/browser_action_custom_bindings.js",
@@ -65,7 +66,7 @@ std::vector<v8::Extension*> GetAll(ExtensionDispatcher* extension_dispatcher) {
};
static const size_t kDependencyCount = arraysize(kDependencies);
- std::vector<v8::Extension*> result;
+ std::vector<ChromeV8Extension*> result;
// Custom bindings that have native code parts.
result.push_back(new ChromePrivateCustomBindings(

Powered by Google App Engine
This is Rietveld 408576698