Implement a module system for the extension bindings JS.

chrome/renderer/extensions/json_schema_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/string_util.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/test/base/v8_unit_test.h"
 #include "grit/renderer_resources.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/resource/resource_bundle.h"
 
 static const char kJsonSchema[] = "json_schema.js";
 static const char kJsonSchemaTest[] = "json_schema_test.js";
 
 class JsonSchemaTest : public V8UnitTest {
  public:
   JsonSchemaTest() {}
 
   virtual void SetUp() {
     V8UnitTest::SetUp();
 
     // Add the json schema code to the context.
     std::string code = ResourceBundle::GetSharedInstance().GetRawDataResource(
         IDR_JSON_SCHEMA_JS).as_string();
 
-    // This is a nasty hack, but it is easier to test the code if we don't use
-    // it as a v8 extension. So replace the only bit that relies on that with a
-    // more easily testable implementation.
-    ReplaceFirstSubstringAfterOffset(&code, 0,
-        "native function GetChromeHidden();",
-        "function GetChromeHidden() {\n"
-        "  if (!this.chromeHidden) this.chromeHidden = {};\n"
-        "  return this.chromeHidden;\n"
-        "}");
+    // json_schema.js expects to have requireNative() defined.
+    ExecuteScriptInContext(
+        "function requireNative(id) {"
+        "  return {"
+        "    GetChromeHidden: function() { return {}; },"
+        "  };"
+        "}",
+        "test-code");
     ExecuteScriptInContext(code, kJsonSchema);
 
     // Add the test functions to the context.
     FilePath test_js_file_path;
     ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &test_js_file_path));
     test_js_file_path = test_js_file_path.AppendASCII("extensions");
     test_js_file_path = test_js_file_path.AppendASCII(kJsonSchemaTest);
     std::string test_js;
     ASSERT_TRUE(file_util::ReadFileToString(test_js_file_path, &test_js));
     ExecuteScriptInContext(test_js, kJsonSchemaTest);
@@ skipping 52 matching lines @@
   TestFunction("testGetAllTypesForSchema");
 }
 
 TEST_F(JsonSchemaTest, TestIsValidSchemaType) {
   TestFunction("testIsValidSchemaType");
 }
 
 TEST_F(JsonSchemaTest, TestCheckSchemaOverlap) {
   TestFunction("testCheckSchemaOverlap");
 }