Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Side by Side Diff: chrome/renderer/resources/extensions/windows_custom_bindings.js

Issue 9386001: Implement a module system for the extension bindings JS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: re-jigged to use ModuleSystem Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Custom bindings for the windows API. 5 // Custom bindings for the windows API.
6 6
7 (function() { 7 (function() {
8 8
9 native function GetChromeHidden(); 9 var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
10 10
11 GetChromeHidden().registerCustomHook('windows', function(api) { 11 chromeHidden.registerCustomHook('windows', function(api) {
12 var apiFunctions = api.apiFunctions; 12 var apiFunctions = api.apiFunctions;
13 13
14 apiFunctions.setUpdateArgumentsPreValidate("windows.get", function() { 14 apiFunctions.setUpdateArgumentsPreValidate("windows.get", function() {
15 // Old signature: 15 // Old signature:
16 // get(int windowId, function callback); 16 // get(int windowId, function callback);
17 // New signature: 17 // New signature:
18 // get(int windowId, object populate, function callback); 18 // get(int windowId, object populate, function callback);
19 if (arguments.length == 2 && typeof(arguments[1]) == "function") { 19 if (arguments.length == 2 && typeof(arguments[1]) == "function") {
20 // If the old signature is used, add a null populate object. 20 // If the old signature is used, add a null populate object.
21 newArgs = [arguments[0], null, arguments[1]]; 21 newArgs = [arguments[0], null, arguments[1]];
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 // If the old signature is used, add a null populate object. 64 // If the old signature is used, add a null populate object.
65 newArgs = [null, arguments[0]]; 65 newArgs = [null, arguments[0]];
66 } else { 66 } else {
67 newArgs = arguments; 67 newArgs = arguments;
68 } 68 }
69 return newArgs; 69 return newArgs;
70 }); 70 });
71 }); 71 });
72 72
73 })(); 73 })();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698