Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Side by Side Diff: chrome/renderer/resources/extensions/tabs_custom_bindings.js

Issue 9386001: Implement a module system for the extension bindings JS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: re-jigged to use ModuleSystem Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Custom bindings for the tabs API. 5 // Custom bindings for the tabs API.
6 6
7 (function() { 7 (function() {
8 8
9 native function GetChromeHidden(); 9 var tabs = requireNative('tabs');
10 native function OpenChannelToTab(); 10 var OpenChannelToTab = tabs.OpenChannelToTab;
11 11
12 var chromeHidden = GetChromeHidden(); 12 var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
13 13
14 chromeHidden.registerCustomHook('tabs', function(bindingsAPI, extensionId) { 14 chromeHidden.registerCustomHook('tabs', function(bindingsAPI, extensionId) {
15 var apiFunctions = bindingsAPI.apiFunctions; 15 var apiFunctions = bindingsAPI.apiFunctions;
16 16
17 apiFunctions.setHandleRequest('tabs.connect', function(tabId, connectInfo) { 17 apiFunctions.setHandleRequest('tabs.connect', function(tabId, connectInfo) {
18 var name = ''; 18 var name = '';
19 if (connectInfo) { 19 if (connectInfo) {
20 name = connectInfo.name || name; 20 name = connectInfo.name || name;
21 } 21 }
22 var portId = OpenChannelToTab(tabId, extensionId, name); 22 var portId = OpenChannelToTab(tabId, extensionId, name);
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 // If the old signature is used, add a null details object. 59 // If the old signature is used, add a null details object.
60 newArgs = [arguments[0], null, arguments[1]]; 60 newArgs = [arguments[0], null, arguments[1]];
61 } else { 61 } else {
62 newArgs = arguments; 62 newArgs = arguments;
63 } 63 }
64 return newArgs; 64 return newArgs;
65 }); 65 });
66 }); 66 });
67 67
68 })(); 68 })();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698