Implement a module system for the extension bindings JS.

chrome/renderer/resources/extensions/chrome_private_custom_bindings.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Custom bindings for the chromePrivate API.
 
-(function() {
-
-native function GetChromeHidden();
-native function DecodeJPEG(jpegImage);
+var GetChromeHidden = natives.GetChromeHidden;

[Aaron Boodman, 2012/02/16 01:54:42]

As long as you're changing these files, you might as well just use natives.Foo
directly instead of creating this alias. Most of them are only used once.

Also, since we're not using the fancy v8 native function technology anymore,
distinguishing these functions specially with a leading capital letter doesn't
seem worthwhile. It would look nicer to name them the same as any other
function, with camelCase.

[koz (OOO until 15th September), 2012/02/27 01:06:14]

I don't know, I kind of like having the native functions defined up-front. And
there's just as much reason to have the names have a leading capital now as
there was before - they still denote native functions, they're just set up in
different ways.

[Aaron Boodman, 2012/02/28 02:42:59]

OK. Elsewhere in this review, I pointed out unix_hacker names also don't adhere
to our js conventions. How do you feel about changing those?

+var DecodeJPEG = natives.DecodeJPEG;
 
 GetChromeHidden().registerCustomHook('chromePrivate', function(bindingsAPI) {
   var apiFunctions = bindingsAPI.apiFunctions;
 
   apiFunctions.setHandleRequest(
       "chromePrivate.decodeJPEG", function(jpeg_image) {
     return DecodeJPEG(jpeg_image);
   });
 });
-
-})();