Implement a module system for the extension bindings JS.

chrome/renderer/extensions/chrome_webstore_bindings.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/chrome_webstore_bindings.h"
 
 #include "base/lazy_instance.h"
 #include "base/string_util.h"
 #include "chrome/common/extensions/extension.h"
+#include "chrome/renderer/extensions/chrome_v8_extension.h"
 #include "chrome/renderer/extensions/extension_helper.h"
 #include "chrome/renderer/weak_v8_function_map.h"
 #include "content/public/renderer/render_view.h"
 #include "googleurl/src/gurl.h"
+#include "grit/renderer_resources.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebDocument.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebElement.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebNode.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebNodeList.h"
 #include "v8/include/v8.h"
 
 using WebKit::WebDocument;
 using WebKit::WebElement;
 using WebKit::WebFrame;
 using WebKit::WebNode;
 using WebKit::WebNodeList;
 
+class ExtensionDispatcher;
+
 namespace {
 
 const char kWebstoreV8ExtensionName[] = "v8/ChromeWebstore";
 
 const char kWebstoreLinkRelation[] = "chrome-webstore-item";
 
 const char kPreferredStoreLinkUrlNotAString[] =
     "The Chrome Web Store item link URL parameter must be a string.";
 const char kSuccessCallbackNotAFunctionError[] =
     "The success callback parameter must be a function.";
@@ skipping 13 matching lines @@
 // (successful or not) via HandleInstallResponse.
 int g_next_install_id = 0;
 
 base::LazyInstance<WeakV8FunctionMap> g_success_callbacks =
     LAZY_INSTANCE_INITIALIZER;
 base::LazyInstance<WeakV8FunctionMap> g_failure_callbacks =
     LAZY_INSTANCE_INITIALIZER;
 
 } // anonymous namespace
 
-class ExtensionImpl : public v8::Extension {
+class ExtensionImpl : public ChromeV8Extension {
  public:
-  ExtensionImpl() :
-    v8::Extension(
-        kWebstoreV8ExtensionName,
-        "var chrome = chrome || {};"
-        "if (!chrome.webstore) {"
-        "  chrome.webstore = new function() {"
-        "    native function Install(preferredStoreUrl, onSuccess, onFailure);"
-        "    this.install = Install;"
-        "  };"
-        "}") {
-  }
+  explicit ExtensionImpl(ExtensionDispatcher* dispatcher) :
+    ChromeV8Extension(kWebstoreV8ExtensionName, IDR_WEBSTORE_BINDINGS_JS,
+        dispatcher) {}
 
-  virtual v8::Handle<v8::FunctionTemplate> GetNativeFunction(
-      v8::Handle<v8::String> name) {
-    if (name->Equals(v8::String::New("Install"))) {
-      return v8::FunctionTemplate::New(Install);
-    } else {
-      return v8::Handle<v8::FunctionTemplate>();
-    }
+  virtual void SetNativeFunctions(v8::Handle<v8::Object> object) OVERRIDE {
+    RouteFunctionToStatic("WebStoreInstall", Install, object);
   }
 
   static v8::Handle<v8::Value> Install(const v8::Arguments& args) {
     WebFrame* frame = WebFrame::frameForCurrentContext();
     if (!frame || !frame->view())
       return v8::Undefined();
 
     content::RenderView* render_view =
         content::RenderView::FromWebView(frame->view());
     if (!render_view)
@@ skipping 128 matching lines @@
       *webstore_item_id = candidate_webstore_item_id;
       return true;
     }
 
     *error = kNoWebstoreItemLinkFoundError;
     return false;
   }
 };
 
 // static
-v8::Extension* ChromeWebstoreExtension::Get() {
-  return new ExtensionImpl();
+ChromeV8Extension* ChromeWebstoreExtension::Get(
+    ExtensionDispatcher* dispatcher) {
+  return new ExtensionImpl(dispatcher);
 }
 
 // static
 void ChromeWebstoreExtension::HandleInstallResponse(int install_id,
                                                     bool success,
                                                     const std::string& error) {
   WeakV8FunctionMap& callback_map =
       success ? g_success_callbacks.Get() : g_failure_callbacks.Get();
 
   v8::Persistent<v8::Function> function = callback_map.Remove(install_id);
   if (function.IsEmpty())
     return;
 
   v8::HandleScope handle_scope;
   v8::Context::Scope context_scope(function->CreationContext());
   v8::Handle<v8::Value> argv[1];
   argv[0] = v8::String::New(error.c_str());
   function->Call(v8::Object::New(), arraysize(argv), argv);
 }