Implement a module system for the extension bindings JS.

chrome/renderer/extensions/chrome_v8_context.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/chrome_v8_context.h"
 
 #include "base/logging.h"
+#include "base/stl_util.h"
 #include "base/string_split.h"
 #include "base/values.h"
 #include "chrome/common/extensions/extension_set.h"
 #include "chrome/renderer/extensions/chrome_v8_extension.h"
 #include "content/public/renderer/render_view.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebView.h"
 #include "v8/include/v8.h"
 
 namespace {
 
 const char kChromeHidden[] = "chromeHidden";
 
 #ifndef NDEBUG
 const char kValidateCallbacks[] = "validateCallbacks";
 #endif
 
 }  // namespace
 
 
 ChromeV8Context::ChromeV8Context(v8::Handle<v8::Context> v8_context,
                                  WebKit::WebFrame* web_frame,
                                  const std::string& extension_id)
     : v8_context_(v8::Persistent<v8::Context>::New(v8_context)),
+      natives_(v8::Persistent<v8::Object>::New(v8::Object::New())),

[Aaron Boodman, 2012/02/16 01:54:42]

Seems like this object should be created in v8_context_. In order to do that you
will need to create it in the constructor inside a v8::Context::Scope for
v8_context_.

       web_frame_(web_frame),
       extension_id_(extension_id) {
   VLOG(1) << "Created context for extension\n"
           << "  id:    " << extension_id << "\n"
           << "  frame: " << web_frame_;
 }
 
 ChromeV8Context::~ChromeV8Context() {
   VLOG(1) << "Destroyed context for extension\n"
           << "  id:    " << extension_id_;
   v8_context_.Dispose();
+  STLDeleteElements(&extensions_);

[Aaron Boodman, 2012/02/16 01:54:42]

Use base/memory/linked_ptr instead of doing this manually.

[koz (OOO until 15th September), 2012/02/27 01:06:14]

Done.

+  natives_.Dispose();
 }
 
 // static
 v8::Handle<v8::Value> ChromeV8Context::GetOrCreateChromeHidden(
     v8::Handle<v8::Context> context) {
   v8::Local<v8::Object> global = context->Global();
   v8::Local<v8::Value> hidden = global->GetHiddenValue(
       v8::String::New(kChromeHidden));
 
   if (hidden.IsEmpty() || hidden->IsUndefined()) {
@@ skipping 67 matching lines @@
   argv[1] = v8::Boolean::New(is_extension_process);
   argv[2] = v8::Boolean::New(is_incognito_process);
   argv[3] = v8::Integer::New(manifest_version);
   CallChromeHiddenMethod("dispatchOnLoad", arraysize(argv), argv, NULL);
 }
 
 void ChromeV8Context::DispatchOnUnloadEvent() const {
   v8::HandleScope handle_scope;
   CallChromeHiddenMethod("dispatchOnUnload", 0, NULL, NULL);
 }
+
+void ChromeV8Context::RegisterExtension(ChromeV8Extension* extension) {
+  extensions_.push_back(extension);
+  extension->SetNativeFunctions(natives_);
+}