third_party/icon_family/README.chromium - Issue 9385035: Minor fixes to IconFamily library

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/icon_family/README.chromium

Issue 9385035: Minor fixes to IconFamily library (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: typo Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/icon_family/NSString+CarbonFSRefCreation.m ('K') | « third_party/icon_family/NSString+CarbonFSRefCreation.m ('k') | third_party/icon_family/icon_family.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/icon_family/README.chromium

diff --git a/third_party/icon_family/README.chromium b/third_party/icon_family/README.chromium

index a03d40cf293cef1b16f444c21d7f8e2734b97c8d..4b4925077610ee66754a2f6ac4c7ba2d76db1589 100644

--- a/third_party/icon_family/README.chromium

+++ b/third_party/icon_family/README.chromium

@@ -11,4 +11,5 @@ Description:

This is an Objective-C wrapper around Mac OS X Icon Services' "IconFamily" data type. This is used to create .icns files for Web Apps installed from the browser.

Local Modifications:

-None

+Fix minor erors and warnings.

+Put code that the custom icon code behind a DISABLE_CUSTOM_ICON flag.

Nico 2012/02/11 02:53:16 Can you add a link to the review, or check in a pa

sail 2012/02/11 03:40:38 Done.