Minor fixes to IconFamily library

Minor fixes to IconFamily library

This change fixes some minor errors and warnings.

Also put the custom icon code behind a DISABLE_CUSTOM_ICON flag. This code wasn't used by the browser and it was emitting some warnings.

BUG=112651
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121643

[sail, 2012-02-11 02:43:34]

These are the modifications I need to be able to compile IconFamily without
errors or warnings.

I"ve sent a copy of this patch to the SourceForge project:
https://sourceforge.net/tracker/?func=detail&aid=3486693&group_id=164783&atid...

[Nico, 2012-02-11 02:53:16]

lgtm with patch or link to review in readme

https://chromiumcodereview.appspot.com/9385035/diff/2001/third_party/icon_fam...
File third_party/icon_family/NSString+CarbonFSRefCreation.m (right):

https://chromiumcodereview.appspot.com/9385035/diff/2001/third_party/icon_fam...
third_party/icon_family/NSString+CarbonFSRefCreation.m:26: if
(![(NSData*)[NSData data] writeToFile:self atomically:YES]) {
What's this needed for?

…nevermind. Ugh!

https://chromiumcodereview.appspot.com/9385035/diff/2001/third_party/icon_fam...
File third_party/icon_family/README.chromium (right):

https://chromiumcodereview.appspot.com/9385035/diff/2001/third_party/icon_fam...
third_party/icon_family/README.chromium:15: Put code that the custom icon code
behind a DISABLE_CUSTOM_ICON flag.
Can you add a link to the review, or check in a patch file (see some other 3rd
party directories)?

[sail, 2012-02-11 03:40:38]

https://chromiumcodereview.appspot.com/9385035/diff/2001/third_party/icon_fam...
File third_party/icon_family/README.chromium (right):

https://chromiumcodereview.appspot.com/9385035/diff/2001/third_party/icon_fam...
third_party/icon_family/README.chromium:15: Put code that the custom icon code
behind a DISABLE_CUSTOM_ICON flag.
On 2012/02/11 02:53:16, Nico wrote:
> Can you add a link to the review, or check in a patch file (see some other 3rd
> party directories)?

Done.

[commit-bot: I haz the power, 2012-02-11 06:53:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/9385035/2002

[commit-bot: I haz the power, 2012-02-11 08:15:44]

Change committed as 121643

[jeremy, 2012-02-12 08:31:48]

Already landed, but fwiw lgtm :)