Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 9385023: Add an environment variable to Virtual Me2Me session. (Closed)

Created:
8 years, 10 months ago by Lambros
Modified:
8 years, 10 months ago
Reviewers:
Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, pam+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Add an environment variable to Virtual Me2Me session. This allows users to write session startup scripts (~/.xsessionrc etc) with parts that are conditional on a Virtual Me2Me session, for example: if [ -n "$REMOTING_ME2ME" ]; then do stuff only in a ME2ME virtual session fi BUG=None TEST=Manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121603

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M remoting/tools/me2me_virtual_host.py View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Lambros
8 years, 10 months ago (2012-02-10 23:32:11 UTC) #1
Jamie
lgtm with a couple of suggestions. http://codereview.chromium.org/9385023/diff/1/remoting/tools/me2me_virtual_host.py File remoting/tools/me2me_virtual_host.py (right): http://codereview.chromium.org/9385023/diff/1/remoting/tools/me2me_virtual_host.py#newcode292 remoting/tools/me2me_virtual_host.py:292: "REMOTING_ME2ME": "y" } ...
8 years, 10 months ago (2012-02-10 23:35:06 UTC) #2
Lambros
http://codereview.chromium.org/9385023/diff/1/remoting/tools/me2me_virtual_host.py File remoting/tools/me2me_virtual_host.py (right): http://codereview.chromium.org/9385023/diff/1/remoting/tools/me2me_virtual_host.py#newcode292 remoting/tools/me2me_virtual_host.py:292: "REMOTING_ME2ME": "y" } On 2012/02/10 23:35:07, Jamie wrote: > ...
8 years, 10 months ago (2012-02-11 01:22:07 UTC) #3
Jamie
8 years, 10 months ago (2012-02-11 01:24:18 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698